test: update Checkbox tests to use react testing library #1341

scurker · 2024-02-07T22:57:52Z

aws-amplify-us-east-1 · 2024-02-08T15:29:02Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1341.d15792l1n26ww3.amplifyapp.com

packages/react/src/components/Checkbox/Checkbox.test.tsx

JoshMK

Looks amazing! 🙌 Just left a small change request on two tests.

‎

scurker added 3 commits February 7, 2024 16:57

test: update Checkbox tests to use react testing library

1ad5e1b

user event

b64e754

type

6b8cd31

more coverage

6839e29

scurker marked this pull request as ready for review February 8, 2024 15:58

scurker requested a review from a team as a code owner February 8, 2024 15:58

scurker requested a review from a team February 8, 2024 16:41

JoshMK reviewed Feb 8, 2024

View reviewed changes

packages/react/src/components/Checkbox/Checkbox.test.tsx Show resolved Hide resolved

JoshMK previously requested changes Feb 8, 2024

View reviewed changes

add focus checks

5553fb3

scurker requested a review from JoshMK February 9, 2024 15:25

JoshMK approved these changes Feb 9, 2024

View reviewed changes

scurker merged commit f6a8495 into develop Feb 9, 2024
6 checks passed

scurker deleted the checkbox-rtl-tests branch February 9, 2024 16:29

Provide feedback