Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): announce required once through attribute only #1294

Closed
wants to merge 1 commit into from

Conversation

JoshMK
Copy link
Contributor

@JoshMK JoshMK commented Nov 17, 2023

  • uses the required attribute to announce 'required' to screen readers while still displaying 'required' for sighted users.
required being announced on TextField component once to screenreader users while being displayed to sighted users

Closes: #1293

@JoshMK JoshMK requested a review from a team as a code owner November 17, 2023 19:34
@JoshMK JoshMK changed the title fix: announce required once through attribute only fix(react): announce required once through attribute only Nov 17, 2023
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1294.d15792l1n26ww3.amplifyapp.com

@JoshMK
Copy link
Contributor Author

JoshMK commented Nov 17, 2023

Closing this out pending further discussion of the best way to handle cases where requiredText is customized by the user.

@JoshMK JoshMK closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: required TextField components announces required twice
1 participant