-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): add Combobox component #1180
Conversation
Preview branch generated at https://combobox.d1gko6en628vir.amplifyapp.com |
Is there a way to change the default icon on a selected option? Not sure about what use cases we have in mind for this but as a general use ui library I'd definitely want that. |
That's more of a @dequelabs/cauldron-design question than something I can answer here. They have mentioned wanting to have more alignment and consistency between teams, so we might not need this white labeled out of the box until we identify the need to do so. |
Preview branch generated at https://combobox.d1gko6en628vir.amplifyapp.com |
closes #1088
Reviewers should make themselves familiar with Comboboxes, the aria authoring practices guide is particularly useful as a primer:
https://www.w3.org/WAI/ARIA/apg/patterns/combobox/