Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): add Combobox component #1180

Merged
merged 64 commits into from
Sep 6, 2023
Merged

feat(react): add Combobox component #1180

merged 64 commits into from
Sep 6, 2023

Conversation

scurker
Copy link
Member

@scurker scurker commented Aug 23, 2023

closes #1088

Reviewers should make themselves familiar with Comboboxes, the aria authoring practices guide is particularly useful as a primer:
https://www.w3.org/WAI/ARIA/apg/patterns/combobox/

@github-actions
Copy link
Contributor

Preview branch generated at https://combobox.d1gko6en628vir.amplifyapp.com

@qazwsxedcrfvtgb1111
Copy link
Contributor

Is there a way to change the default icon on a selected option? Not sure about what use cases we have in mind for this but as a general use ui library I'd definitely want that.

@scurker
Copy link
Member Author

scurker commented Aug 31, 2023

Is there a way to change the default icon on a selected option? Not sure about what use cases we have in mind for this but as a general use ui library I'd definitely want that.

That's more of a @dequelabs/cauldron-design question than something I can answer here. They have mentioned wanting to have more alignment and consistency between teams, so we might not need this white labeled out of the box until we identify the need to do so.

@scurker scurker requested a review from a team September 1, 2023 00:56
thuey
thuey previously approved these changes Sep 5, 2023
@scurker scurker merged commit 4d29227 into develop Sep 6, 2023
7 checks passed
@scurker scurker deleted the combobox branch September 6, 2023 19:00
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Preview branch generated at https://combobox.d1gko6en628vir.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combobox Component (Single Select)
4 participants