Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breadcrumbs): amend / separator colours in light and dark mode #1153

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

Zidious
Copy link
Contributor

@Zidious Zidious commented Aug 7, 2023

This PR updates the colours used for the / in light and dark mode.

@Zidious Zidious requested a review from a team as a code owner August 7, 2023 19:53
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Preview branch generated at https://fix-separator-color.d1gko6en628vir.amplifyapp.com

scurker
scurker previously requested changes Aug 7, 2023
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. We need to split out the changes so that padding is only listed once.

packages/styles/breadcrumb.css Outdated Show resolved Hide resolved
@Zidious Zidious requested a review from scurker August 8, 2023 16:12
@Zidious Zidious merged commit f2f134b into develop Aug 8, 2023
2 checks passed
@Zidious Zidious deleted the fix-separator-color branch August 8, 2023 16:41
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Preview branch generated at https://fix-separator-color.d1gko6en628vir.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants