Skip to content

Commit

Permalink
fix: comments and mistakes after resolving conflicts
Browse files Browse the repository at this point in the history
  • Loading branch information
orest-s committed Jan 5, 2024
1 parent 3f06820 commit 0d22e22
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 12 deletions.
4 changes: 4 additions & 0 deletions docs/pages/components/ProgressBar.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ import { ProgressBar } from '@deque/cauldron-react'

## Examples

### Thin

```jsx example
<ProgressBar
aria-label="Progress %"
Expand All @@ -21,6 +23,8 @@ import { ProgressBar } from '@deque/cauldron-react'
/>
```

### Normal

```jsx example
<ProgressBar
aria-label="Progress %"
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/ProgressBar/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const ProgressBar = forwardRef<HTMLDivElement, ProgressBarProps>(
const { className, ...otherProps } = props;
return (
<div
className={classnames(className, 'Progressbar', {
className={classnames(className, 'ProgressBar', {
'ProgressBar--thin': thin
})}
role="progressbar"
Expand Down
19 changes: 8 additions & 11 deletions packages/styles/progressbar.css
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,15 @@
--progress-bar-animation-timing: 150ms;
}

.cauldron--theme-dark {
--progress-bar-background-color: var(--accent-dark);
--progress-bar-fill-color: var(--accent-info-light);
--progress-bar-border-color: var(--progress-bar-background-color);
}

.ProgressBar {
background-color: var(--progress-bar-background-color);
padding: var(--space-half);
padding: 3px;
border-radius: calc((var(--space-small) * 0.5) + 2px);
border: 1px solid var(--progress-bar-border-color);
margin-bottom: var(--space-smallest);
Expand All @@ -22,14 +28,5 @@
}

.ProgressBar--thin .ProgressBar--fill {
height: var(--space-smallest);
}

.cauldron--theme-dark {
--progress-bar-background-color: var(--accent-dark);
--progress-bar-fill-color: var(--accent-info-light);
}

.cauldron--theme-dark .ProgressBar {
border: none;
height: 8px;
}

0 comments on commit 0d22e22

Please sign in to comment.