Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(.github/action): change the create-release-candidate action #161

Merged
merged 1 commit into from
Apr 25, 2024
Merged

ci(.github/action): change the create-release-candidate action #161

merged 1 commit into from
Apr 25, 2024

Conversation

maksym-shynkarenko
Copy link
Contributor

Added to the create-release-candidate action the optional docs-labels input, changed the project number and column names, and changed the release-issue content.

Closes: #501

@maksym-shynkarenko maksym-shynkarenko requested a review from a team as a code owner April 24, 2024 12:21
Zidious
Zidious requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@Zidious Zidious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had two questions inline -

.github/actions/create-release-candidate-v1/README.md Show resolved Hide resolved
.github/actions/create-release-candidate-v1/action.yml Show resolved Hide resolved
Zidious
Zidious approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@Zidious Zidious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -

For future us, discussed offline now we'll have one docs repo that houses all documentation and not all repos that use this flow will want to have release and PRIORITY: high labels attached by default, the default behaviour will be no labels.

@maksym-shynkarenko maksym-shynkarenko merged commit db854d0 into main Apr 25, 2024
15 checks passed
@maksym-shynkarenko maksym-shynkarenko deleted the ci-change-create-release-candidate-action branch April 25, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zidious Zidious Zidious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maksym-shynkarenko @Zidious