Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only run build in changed dirs #124

Merged
merged 1 commit into from
Jan 10, 2024
Merged

chore: only run build in changed dirs #124

merged 1 commit into from
Jan 10, 2024

Conversation

straker
Copy link
Contributor

@straker straker commented Jan 9, 2024

This change allows the lint-staged command to only run the build in the workspace where files changed. That way we don't run the build for every workspace and the prs are scoped to only where the changes happened.

Also making sure the pr for generating the files has body text.

no qa required

@straker straker requested a review from a team as a code owner January 9, 2024 23:18
Copy link
Contributor

@Zidious Zidious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +12 to +15
# get only the unique values from an array
# `lines[$i]%%/*` gets the substring up to the first '/'. so `semantic-pr-footer-v1/src/run.ts` becomes `semantic-pr-footer-v1`
# @see https://www.baeldung.com/linux/bash-unique-values-arrays
unique_dirs=($(for (( i=0; i<${#lines[@]}; i++ )) ; do echo "${lines[$i]%%/*}"; done | sort -u))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@straker straker merged commit 2798b66 into main Jan 10, 2024
15 of 16 checks passed
@straker straker deleted the robot-stuff branch January 10, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants