Skip to content

Commit

Permalink
chore: fix husky precommit hook not running code in bash (#125)
Browse files Browse the repository at this point in the history
* new approach

* push main
  • Loading branch information
straker authored Jan 10, 2024
1 parent 2798b66 commit 1f6ffb0
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 26 deletions.
27 changes: 27 additions & 0 deletions .husky/build-changed-files.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
#!/bin/bash

# only run the npm build script for each workspace directory that has changed files
function run_build {
# convert multiline string into array
# @see https://stackoverflow.com/questions/24628076/convert-multiline-string-to-array
local IFS=$'\n'
local lines=($1)
local i

# get only the unique values from an array
# `lines[$i]%%/*` gets the substring up to the first '/'. so `semantic-pr-footer-v1/src/run.ts` becomes `semantic-pr-footer-v1`
# @see https://www.baeldung.com/linux/bash-unique-values-arrays
unique_dirs=($(for (( i=0; i<${#lines[@]}; i++ )) ; do echo "${lines[$i]%%/*}"; done | sort -u))

for dir in "${unique_dirs[@]}"; do
npm run build -w "$dir"
done
}

cd "$(dirname -- "$0")/../.github/actions"
files=$(git diff HEAD~1 --name-only --relative)
if [ "$files" != "" ]; then
run_build "$files"
fi

git add .
30 changes: 4 additions & 26 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,30 +1,8 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

# only run the npm build script for each workspace directory that has changed files
function run_build {
# convert multiline string into array
# @see https://stackoverflow.com/questions/24628076/convert-multiline-string-to-array
local IFS=$'\n'
local lines=($1)
local i

# get only the unique values from an array
# `lines[$i]%%/*` gets the substring up to the first '/'. so `semantic-pr-footer-v1/src/run.ts` becomes `semantic-pr-footer-v1`
# @see https://www.baeldung.com/linux/bash-unique-values-arrays
unique_dirs=($(for (( i=0; i<${#lines[@]}; i++ )) ; do echo "${lines[$i]%%/*}"; done | sort -u))

for dir in "${unique_dirs[@]}"; do
npm run build -w "$dir"
done
}

cd ./.github/actions
files=$(git diff HEAD~1 --name-only --relative)
if [ "$files" != "" ]; then
run_build "$files"
fi

cd ../../
git add .
# this file requires bash to run in github actions (github
# actions use dash as default `sh` command)
# @see https://github.com/typicode/husky/issues/1326
bash "$(dirname -- "$0")/build-changed-files.sh"
npx lint-staged

0 comments on commit 1f6ffb0

Please sign in to comment.