Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies (including circle -> gha) #47

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Jun 20, 2024

Test run: https://github.com/dequelabs/dbjorge-test-repo/actions/runs/9604481533/job/26490058201

Notes on the updates:

  • I blew away the whole lockfile and updated everything listed in package.json to latest
  • ...except eslint, which I left at major version 8 for compat with typescript-eslint's current stable version
  • ...and except a few dev deps that I dropped because we weren't using them anyway (eslint+tslint stuff, sinon)
  • The octokit update bumps octokit to a version that uses native fetch, which nock can't mock, so I added a test seam that forces octokit to use node-fetch when NODE_ENV === 'test'. The alternatives would be to use a beta version of nock (didn't want to use a beta version of anything in a repo we update so rarely) or to use a different mocking library (fetch-mock was the best-looking option but it required more test changes than I wanted to spend time on to swap it out)

I included a conversion from circle to GHA because I hit errors when naively updating the circle config to node 20 and it was faster to convert than to debug circle. None of the failed checks are relevant anymore; once this merges we can disable circle in this repo and update the branch policies to refer to GHA.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@dbjorge dbjorge marked this pull request as ready for review June 20, 2024 21:17
@dbjorge dbjorge changed the title chore: update deps chore: update dependencies (including circle -> gha) Jun 20, 2024
opts.log = console
}
if (process.env.NODE_ENV === 'test') {
// See https://github.com/nock/nock/issues/2183
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, interesting

@scurker
Copy link
Member

scurker commented Jun 21, 2024

🚨 Reviewed for Security 🚨

@dbjorge dbjorge merged commit 0453a2a into develop Jun 21, 2024
3 of 4 checks passed
@dbjorge dbjorge deleted the update-deps branch June 21, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants