[NO_JIRA] 블록별 좌석 범위 조회 API request 수정 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EunjiShin
commented
Jul 18, 2024
|
|
||
| import org.depromeet.spot.jpa.block.entity.BlockEntity; | ||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
|
|
||
| public interface BlockJpaRepository extends JpaRepository<BlockEntity, Long> { | ||
| Optional<BlockEntity> findByStadiumIdAndCode(Long stadiumId, String code); |
There was a problem hiding this comment.
블럭 코드는 경기장 내에서만 unique하기 때문에, stadiumId를 추가로 이용했어요~
EunjiShin
commented
Jul 18, 2024
Comment on lines
+52
to
+57
| @Override | ||
| public List<BlockRow> findAllByStadiumAndBlock(Long stadiumId, String blockCode) { | ||
| List<BlockRowEntity> entities = | ||
| blockRowJpaRepository.findAllByStadiumAndBlock(stadiumId, blockCode); | ||
| return entities.stream().map(BlockRowEntity::toDomain).toList(); | ||
| } |
There was a problem hiding this comment.
요건 생각해보니까, 어차피 로직상 stadiumId랑 code로 블럭을 먼저 찾을테니, 이후 blockId만 get해서 써도 되겠네요..!
이렇게 구현해도 딱히 문제는 없으니까 일단 현상 유지할게요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요 (필수)
🔨 작업 사항 (필수)
💻 실행 화면 (필수)