Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-19199: Adds Manila VA Clinic to Menu Breadcrumbs #19401

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Oct 3, 2024

Description

Relates to #19199

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 3, 2024 16:52 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 4, 2024 08:45 Destroyed
@eselkin
Copy link
Contributor

eselkin commented Oct 4, 2024

After building several times with this setting enabled I've noticed several things

The menus still need a <nolink> parent or else they become unclickable (a "feature" of vets-website)

We need to bypass the thrown error on build in content-build when this is enabled and the system is not published. It's the only facility that causes this error, so we may want an exception rather than just disabling the thrown error in general.

I haven't gotten a simple link to point to the facility rather than the system on this PR branch. Policies definitely doesn't let me point to the facility.

@va-cms-bot
Copy link
Collaborator

va/tests/status-error:


entity_update
Title Entity/field definitions
Severity Error
Sid 2
Description The following changes were detected in the entity type and field definitions.
.... Translation Job Item

         * The /File count/ field needs to be uninstalled.                            

Value Mismatched entity and/or field definitions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants