Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VACMS-17854: phpstan fixes #19361

Closed
wants to merge 7 commits into from
Closed

VACMS-17854: phpstan fixes #19361

wants to merge 7 commits into from

Conversation

dsasser
Copy link
Contributor

@dsasser dsasser commented Oct 1, 2024 •
edited
Loading

Description

Just fixes for phpstan/reviewdog

Relates to #17854

Testing done

Automated.

QA steps

  • Automated tests pass

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

davidmpickett and others added 7 commits September 30, 2024 16:29
@davidmpickett
[docs] Update runbook-new-vamc-system.md
2493be3
@davidmpickett
[docs] Update runbook-new-vamc-system.md
fe7aad3
@davidmpickett
[docs] Update runbook-new-vamc-system.md
ce10cfb
@davidmpickett
[docs]Update runbook-new-vamc-system.md
f47def6
@dependabot
Bump va-gov/content-build from 0.0.3603 to 0.0.3604 (#19358)
59cbcd5 
Bumps [va-gov/content-build](https://github.com/department-of-veterans-affairs/content-build) from 0.0.3603 to 0.0.3604.
- [Release notes](https://github.com/department-of-veterans-affairs/content-build/releases)
- [Commits](department-of-veterans-affairs/content-build@v0.0.3603...v0.0.3604)

---
updated-dependencies:
- dependency-name: va-gov/content-build
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dsasser
Merge remote-tracking branch 'origin/main' into VACMS-17854-integrati…
b223b9d 
…on-phone-number-migrations
@dsasser
VACMS-17854: Fix phpstan warnings.
b1dff4a
@dsasser dsasser requested review from a team as code owners October 1, 2024 05:15
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 05:15 Destroyed
@github-actions github-actions bot changed the title Vacms 17854 phpstan fixes VACMS-17854: phpstan fixes Oct 1, 2024
@dsasser dsasser changed the base branch from main to VACMS-17854-integration-phone-number-migrations October 1, 2024 05:21
@dsasser dsasser requested a review from a team as a code owner October 1, 2024 05:21
@dsasser dsasser closed this Oct 1, 2024
@dsasser dsasser deleted the VACMS-17854-phpstan-fixes branch October 1, 2024 05:26
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 05:28 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 08:41 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 13:30 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 14:16 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsasser @va-cms-bot @davidmpickett