Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-18819: Adjust Featured UI #19356

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

davidmpickett
Copy link
Contributor

@davidmpickett davidmpickett commented Sep 30, 2024

Description

Relates to #18819

Testing done

Manual in Tugboat

Screenshots

Screenshot 2024-09-30 at 12 18 45 PM

Screenshot 2024-09-30 at 12 18 51 PM

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As a Content Admin (e.g. [email protected])

  1. Log into the review instance tugboat
  2. Go to Content > Add Content > Story
    • Scroll down to the Feature this story box
    • Notice that the help text for the Featured checkbox is updated
    • Notice that the Order dropdown menu no longer appears
  3. Go to Content > Add Content > Event
    • Expand the Feature this Content accordion in the Right Sidebar
    • Notice that the Order dropdown menu no longer appears
  4. View (but don't edit) the following Stories
  5. View (but don't edit) the following Events

Definition of Done

  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 30, 2024 17:59 Destroyed
@davidmpickett davidmpickett self-assigned this Sep 30, 2024
@davidmpickett davidmpickett requested review from a team September 30, 2024 18:00
@davidmpickett davidmpickett marked this pull request as ready for review September 30, 2024 18:35
Copy link
Contributor

@dsasser dsasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidmpickett davidmpickett merged commit d32bfa1 into main Sep 30, 2024
31 checks passed
@davidmpickett davidmpickett deleted the VACMS-18819-adjust-featured-ui branch September 30, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants