-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE VACMS-17860: Telephone Migrations Integration #19225
Draft
dsasser
wants to merge
17
commits into
main
Choose a base branch
from
VACMS-17854-integration-phone-number-migrations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Workflows (.github/workflows/*.yml)Have you...
|
github-actions
bot
added
DO NOT MERGE
Do not merge this PR
Facilities
Facilities products (VAMC, Vet Center, etc)
labels
Sep 17, 2024
#19038) * VACMS-17860: Adds migration for phone to telephone paragraph for Staff profile content type. * VACMS-17860: Adds codit_batch_operations to codebase. * VACMS-17860: Adds va_gov_batch, tests, and updated CODEOWNERS. * VACMS-17860: Replaces bespoke batch operation with a BatchOperations class. * VACMS-17860: Adds new telephone paragraph field to staff profile. * VACMS-17860: Fixes the phone validation and parsing. * VACMS-17860: Avoids unefined array index warnings. * VACMS-17860: Removes unused method * VACMS-17860: Remove batching configuration in our class because it is already setup in codit. * VACMS-17860: Ensures old phone is not shown on edit form. * VACMS-17860: Fixes extension migration. * VACMS-17860: Updates phone audit view with new phone number paragraph field for staff profile. * VACMS-17860: Restores revision log on staff profile form. * VACMS-17860: Updates cypress test. * VACMS-17860: Fixes typo in CODEOWNERS. * VACMS-17860: PHPCS fix. * VACMS-17860: Fixes selector in cypress test. * VACMS-17861: Minor updates to deploy script. * VACMS-17860: PHPCS fix. * VACMS-17860: Updates nginx config to allow for a larger returned response header. This is necessary when Drupal responsds with a very large cache-context payload. * VACMS-17860: Removes access to the phone label rather than hiding it to prevent php error. * VACMS-17860: Updates nginx config to align with latest ddev default config for D10.
omahane
force-pushed
the
VACMS-17854-integration-phone-number-migrations
branch
from
September 23, 2024 16:44
cfa3243
to
5efde21
Compare
…ld to paragraph (#19234) * VACMS-17862: Adds configuration changes and script to migrating phones * VACMS-17862: Updates the phone number audit view * VACMS-17862: Adds data push changes for mental health * VACMS-17862: Updates the mental health data push code. * VACMS-17862: Accounts for no mental health paragraph * VACMS-17862: Update node and view config * VACMS-17862: Restores revision_log * VACMS-17862: Adds step for filling mental health phone * VACMS-17862: Adds deploy hook and data bypass * VACMS-17862: Fixes path to script-library * VACMS-17862: Add help text * VACMS-17854: Updates composer.lock * Revert "VACMS-17854: Updates composer.lock" This reverts commit 4bb3c93. * Updates the deploy, removing the new one
…ion (#19308) * VACMS-17860: Removes deploy hook for Staff Profile telephone field migration in order to manually perform the migration via drush using codit's drush command. --------- Co-authored-by: Christian Burk <[email protected]>
…telephone paragraph (#19264) * DO NOT MERGE VACMS-17860: Updates staff phone field to paragraph field (#19038) * VACMS-17860: Adds migration for phone to telephone paragraph for Staff profile content type. * VACMS-17860: Adds codit_batch_operations to codebase. * VACMS-17860: Adds va_gov_batch, tests, and updated CODEOWNERS. * VACMS-17860: Replaces bespoke batch operation with a BatchOperations class. * VACMS-17860: Adds new telephone paragraph field to staff profile. * VACMS-17860: Fixes the phone validation and parsing. * VACMS-17860: Avoids unefined array index warnings. * VACMS-17860: Removes unused method * VACMS-17860: Remove batching configuration in our class because it is already setup in codit. * VACMS-17860: Ensures old phone is not shown on edit form. * VACMS-17860: Fixes extension migration. * VACMS-17860: Updates phone audit view with new phone number paragraph field for staff profile. * VACMS-17860: Restores revision log on staff profile form. * VACMS-17860: Updates cypress test. * VACMS-17860: Fixes typo in CODEOWNERS. * VACMS-17860: PHPCS fix. * VACMS-17860: Fixes selector in cypress test. * VACMS-17861: Minor updates to deploy script. * VACMS-17860: PHPCS fix. * VACMS-17860: Updates nginx config to allow for a larger returned response header. This is necessary when Drupal responsds with a very large cache-context payload. * VACMS-17860: Removes access to the phone label rather than hiding it to prevent php error. * VACMS-17860: Updates nginx config to align with latest ddev default config for D10. * VACMS-17854: Updates content-hash * VACMS-17861: Adds telephone field to VAMC Billing and Insurance content type. - Adds migration to move from old field to new paragraph. * VACMS-17861: Removed unwanted deploy hook. * VACMS-17861: Fixing branch rebase issues * VACMS-17861: Ensures old phone number is no longer displayed. * VACMS-17861: Hides phone label using existing method. * VACMS-17861: Resores missing revision_log. --------- Co-authored-by: Christian Burk <[email protected]> Co-authored-by: Jerry Vrabel <[email protected]>
…on-phone-number-migrations
* VACMS-17854: Fix phpstan warnings. * VACMS-17854: Updates function calls with correct type --------- Co-authored-by: Christian Burk <[email protected]>
…on-phone-number-migrations
omahane
force-pushed
the
VACMS-17854-integration-phone-number-migrations
branch
from
October 3, 2024 20:23
1e2aeb6
to
d98f147
Compare
…hub.com:department-of-veterans-affairs/va.gov-cms into VACMS-17854-integration-phone-number-migrations
…on-phone-number-migrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integration branch for telephone migrations.
Relates to #issueid. (or closes?)
Testing done
See each of the individual phone migration PRs for testing steps performed.
QA steps
QA will be performed under #19116
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing
Is this PR blocked by another PR?
DO NOT MERGE
Does this PR need review from a Product Owner
Needs PO review
CMS user-facing announcement
Is an announcement needed to let editors know of this change?