Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE VACMS-17860: Telephone Migrations Integration #19225

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

dsasser
Copy link
Contributor

@dsasser dsasser commented Sep 17, 2024

Description

Integration branch for telephone migrations.

Relates to #issueid. (or closes?)

Testing done

See each of the individual phone migration PRs for testing steps performed.

QA steps

QA will be performed under #19116

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

Copy link

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

@github-actions github-actions bot added DO NOT MERGE Do not merge this PR Facilities Facilities products (VAMC, Vet Center, etc) labels Sep 17, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 17, 2024 17:09 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 17, 2024 19:15 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 17, 2024 23:49 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 18, 2024 08:54 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 19, 2024 08:57 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 19, 2024 14:28 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 20, 2024 08:49 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 21, 2024 08:37 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 22, 2024 08:36 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 23, 2024 08:35 Destroyed
dsasser and others added 2 commits September 23, 2024 10:38
#19038)

* VACMS-17860: Adds migration for phone to telephone paragraph for Staff profile content type.

* VACMS-17860: Adds codit_batch_operations to codebase.

* VACMS-17860: Adds va_gov_batch, tests, and updated CODEOWNERS.

* VACMS-17860: Replaces bespoke batch operation with a BatchOperations class.

* VACMS-17860: Adds new telephone paragraph field to staff profile.

* VACMS-17860: Fixes the phone validation and parsing.

* VACMS-17860: Avoids unefined array index warnings.

* VACMS-17860: Removes unused method

* VACMS-17860: Remove batching configuration in our class because it is already setup in codit.

* VACMS-17860: Ensures old phone is not shown on edit form.

* VACMS-17860: Fixes extension migration.

* VACMS-17860: Updates phone audit view with new phone number paragraph field for staff profile.

* VACMS-17860: Restores revision log on staff profile form.

* VACMS-17860: Updates cypress test.

* VACMS-17860: Fixes typo in CODEOWNERS.

* VACMS-17860: PHPCS fix.

* VACMS-17860: Fixes selector in cypress test.

* VACMS-17861: Minor updates to deploy script.

* VACMS-17860: PHPCS fix.

* VACMS-17860: Updates nginx config to allow for a larger returned response header. This is necessary when Drupal responsds with a very large cache-context payload.

* VACMS-17860: Removes access to the phone label rather than hiding it to prevent php error.

* VACMS-17860: Updates nginx config to align with latest ddev default config for D10.
@omahane omahane force-pushed the VACMS-17854-integration-phone-number-migrations branch from cfa3243 to 5efde21 Compare September 23, 2024 16:44
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 23, 2024 16:44 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 24, 2024 08:47 Destroyed
…ld to paragraph (#19234)

* VACMS-17862: Adds configuration changes and script to migrating phones

* VACMS-17862: Updates the phone number audit view

* VACMS-17862: Adds data push changes for mental health

* VACMS-17862: Updates the mental health data push code.

* VACMS-17862: Accounts for no mental health paragraph

* VACMS-17862: Update node and view config

* VACMS-17862: Restores revision_log

* VACMS-17862: Adds step for filling mental health phone

* VACMS-17862: Adds deploy hook and data bypass

* VACMS-17862: Fixes path to script-library

* VACMS-17862: Add help text

* VACMS-17854: Updates composer.lock

* Revert "VACMS-17854: Updates composer.lock"

This reverts commit 4bb3c93.

* Updates the deploy, removing the new one
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 24, 2024 14:14 Destroyed
…ion (#19308)

* VACMS-17860: Removes deploy hook for Staff Profile telephone field migration in order to manually perform the migration via drush using codit's drush command.

---------

Co-authored-by: Christian Burk <[email protected]>
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 24, 2024 17:21 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 25, 2024 08:38 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 26, 2024 08:40 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 27, 2024 08:40 Destroyed
…telephone paragraph (#19264)

* DO NOT MERGE VACMS-17860: Updates staff phone field to paragraph field (#19038)

* VACMS-17860: Adds migration for phone to telephone paragraph for Staff profile content type.

* VACMS-17860: Adds codit_batch_operations to codebase.

* VACMS-17860: Adds va_gov_batch, tests, and updated CODEOWNERS.

* VACMS-17860: Replaces bespoke batch operation with a BatchOperations class.

* VACMS-17860: Adds new telephone paragraph field to staff profile.

* VACMS-17860: Fixes the phone validation and parsing.

* VACMS-17860: Avoids unefined array index warnings.

* VACMS-17860: Removes unused method

* VACMS-17860: Remove batching configuration in our class because it is already setup in codit.

* VACMS-17860: Ensures old phone is not shown on edit form.

* VACMS-17860: Fixes extension migration.

* VACMS-17860: Updates phone audit view with new phone number paragraph field for staff profile.

* VACMS-17860: Restores revision log on staff profile form.

* VACMS-17860: Updates cypress test.

* VACMS-17860: Fixes typo in CODEOWNERS.

* VACMS-17860: PHPCS fix.

* VACMS-17860: Fixes selector in cypress test.

* VACMS-17861: Minor updates to deploy script.

* VACMS-17860: PHPCS fix.

* VACMS-17860: Updates nginx config to allow for a larger returned response header. This is necessary when Drupal responsds with a very large cache-context payload.

* VACMS-17860: Removes access to the phone label rather than hiding it to prevent php error.

* VACMS-17860: Updates nginx config to align with latest ddev default config for D10.

* VACMS-17854: Updates content-hash

* VACMS-17861: Adds telephone field to VAMC Billing and Insurance content type.
- Adds migration to move from old field to new paragraph.

* VACMS-17861: Removed unwanted deploy hook.

* VACMS-17861: Fixing branch rebase issues

* VACMS-17861: Ensures old phone number is no longer displayed.

* VACMS-17861: Hides phone label using existing method.

* VACMS-17861: Resores missing revision_log.

---------

Co-authored-by: Christian Burk <[email protected]>
Co-authored-by: Jerry Vrabel <[email protected]>
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 27, 2024 16:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 28, 2024 08:40 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 30, 2024 20:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 05:23 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 08:58 Destroyed
omahane and others added 2 commits October 1, 2024 11:05
* VACMS-17854: Fix phpstan warnings.

* VACMS-17854: Updates function calls with correct type

---------

Co-authored-by: Christian Burk <[email protected]>
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 17:21 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 2, 2024 08:39 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 2, 2024 15:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 3, 2024 08:38 Destroyed
@omahane omahane force-pushed the VACMS-17854-integration-phone-number-migrations branch from 1e2aeb6 to d98f147 Compare October 3, 2024 20:23
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 3, 2024 20:23 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 3, 2024 20:31 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 3, 2024 20:42 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 4, 2024 08:37 Destroyed
…hub.com:department-of-veterans-affairs/va.gov-cms into VACMS-17854-integration-phone-number-migrations
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 4, 2024 14:54 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 4, 2024 15:21 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 5, 2024 08:45 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Do not merge this PR Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants