-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-16288 use generated assets for next preview server #16340
Conversation
77e082e
to
44779da
Compare
|
||
# Create symlink between vets-website assets and next-build | ||
# - ln -snf "${DOCROOT}/vendor/va-gov/vets-website/build/localhost/generated" "${TUGBOAT_ROOT}/next/public/generated" | ||
- ln -snf "${TUGBOAT_ROOT}/vets-website/build/localhost/generated" "${TUGBOAT_ROOT}/next/public/generated" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that attempting to symlink to the vets-website installed inside vendor seemed to have issues either creating the symlink or building vets-website later as part of content-build.
Installing & symlinking to a different directory entirely had no issues, the assets are immediately present for the next-build server.
Noting that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again for discussing the approach with me 🙂
Description
Relates to #16288. (or closes?)
next-build needs the assets from vets-website, cms already requests a full content release,
let's re-use those assets to save a little bit of time.Not able to re-use the vets-website built from content-build, issues with symlinks & timing. Easiest approach for now is to build vets-website separately solely for next-build's use.
Testing done
yarn dev
andyarn start
with symlinks from vets-website directories. Ultimately, needed to build and install vets-website at the tugboat root (similar to next-build) and symlink from there. In this way, we can ensure that assets are available for next-build preview immediately without failure.QA steps
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing
Is this PR blocked by another PR?
DO NOT MERGE
Does this PR need review from a Product Owner
Needs PO review
CMS user-facing announcement
Is an announcement needed to let editors know of this change?