Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16152: Adds new view and export #16326

Merged
merged 5 commits into from
Dec 18, 2023

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Dec 6, 2023

Description

Relates to #16152

Testing done

Manually

Screenshots

Screenshot 2023-12-06 at 9 07 07 AM

QA steps

As an admin, go to the Facility services audit view

  • Confirm that it is under the "Content audit tools" section of the Content menu
    • Confirm that it has been added to the end
  • Confirm that multiple content types are showing
  • Confirm that the service term label is showing
  • Confirm that you can filter by content type
  • Confirm that you can filter by section
  • Confirm that you can filter by number of Service locations by setting the filter to greater than 2
    • Export the CSV
    • Confirm that the CSV has the same number of rows and same data as the online form

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 6, 2023 14:23 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 6, 2023 15:06 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 6, 2023 16:08 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 6, 2023 21:44 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 6, 2023 21:53 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 6, 2023 22:01 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 6, 2023 23:43 Destroyed
@omahane omahane force-pushed the VACMS-16152-facility-services-audit-view branch from ec51cb0 to 916ce99 Compare December 7, 2023 00:18
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 7, 2023 12:18 Destroyed
@omahane omahane force-pushed the VACMS-16152-facility-services-audit-view branch from 916ce99 to a24b0e5 Compare December 7, 2023 20:14
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 7, 2023 20:14 Destroyed
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Dec 7, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 8, 2023 17:14 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 8, 2023 17:28 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 8, 2023 17:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 8, 2023 17:45 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 8, 2023 17:51 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 8, 2023 18:00 Destroyed
@omahane omahane force-pushed the VACMS-16152-facility-services-audit-view branch from 5705b4a to 9429133 Compare December 8, 2023 21:05
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 8, 2023 21:05 Destroyed
@swirtSJW
Copy link
Contributor

swirtSJW commented Dec 15, 2023

@omahane
The only thing I see is that the csv does not match our styleguide.

  • CSV export (optional)
    • matches filters from main View
    • Times should be spreadsheet sortable (Y-m-d H:ia)
    • Batch increment 500
    • Edit and/or View URLs should be provided, prefixed with prod domain'https://prod.cms.va.gov/'
    • Filename should be meaningful (usually matching View title)

image

@omahane omahane force-pushed the VACMS-16152-facility-services-audit-view branch from 9429133 to a283f65 Compare December 15, 2023 22:53
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 15, 2023 22:53 Destroyed
@omahane
Copy link
Contributor Author

omahane commented Dec 18, 2023

@swirtSJW I've updated the export to match the style guide.

Copy link
Contributor

@swirtSJW swirtSJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @omahane

@swirtSJW
Copy link
Contributor

image

@swirtSJW swirtSJW force-pushed the VACMS-16152-facility-services-audit-view branch from a283f65 to fd0bfb2 Compare December 18, 2023 20:04
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2023 20:05 Destroyed
@swirtSJW swirtSJW merged commit 1c77cfa into main Dec 18, 2023
13 checks passed
@swirtSJW swirtSJW deleted the VACMS-16152-facility-services-audit-view branch December 18, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants