Skip to content

Commit

Permalink
VACMS-2108 VA Form modifications (#2116)
Browse files Browse the repository at this point in the history 
* VACMS-2108 Capitalize title to VA on form migration.

* VACMS-2108 Add Veteran Affairs to VA form View administrator filter.

* VACMS-2108 Make va_form use the field_va_form_usage for meta description.

* VACMS-2108 Change default owner of va_form to Public Websites > Forms.

* VACMS-2108 Move content add VA Form menu item to alphabetical location.

* VACMS-2108 Adjust form migration title.
  • Loading branch information
@swirtSJW
swirtSJW authored Jun 24, 2020
1 parent 96f8407 commit 81deee5
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 12 deletions.
22 changes: 14 additions & 8 deletions config/sync/core.menu.static_menu_link_overrides.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,19 +42,19 @@ definitions:
expanded: false
enabled: true
node__add__health_care_local_facility:
weight: 26
weight: 27
menu_name: admin
parent: admin_toolbar_tools.add_content
expanded: false
enabled: true
node__add__health_care_region_page:
weight: 23
weight: 24
menu_name: admin
parent: admin_toolbar_tools.add_content
expanded: false
enabled: true
node__add__health_care_local_health_service:
weight: 27
weight: 28
menu_name: admin
parent: admin_toolbar_tools.add_content
expanded: false
Expand Down Expand Up @@ -84,7 +84,7 @@ definitions:
expanded: false
enabled: true
node__add__regional_health_care_service_des:
weight: 28
weight: 29
menu_name: admin
parent: admin_toolbar_tools.add_content
expanded: false
Expand Down Expand Up @@ -282,13 +282,13 @@ definitions:
expanded: false
enabled: true
node__add__full_width_banner_alert:
weight: 24
weight: 25
menu_name: admin
parent: admin_toolbar_tools.add_content
expanded: false
enabled: true
node__add__vamc_operating_status_and_alerts:
weight: 25
weight: 26
menu_name: admin
parent: admin_toolbar_tools.add_content
expanded: false
Expand Down Expand Up @@ -522,16 +522,22 @@ definitions:
expanded: false
enabled: true
node__add__vba_facility:
weight: 29
weight: 30
menu_name: admin
parent: admin_toolbar_tools.add_content
expanded: false
enabled: true
node__add__vet_center:
weight: 30
weight: 31
menu_name: admin
parent: admin_toolbar_tools.add_content
expanded: false
enabled: true
node__add__va_form:
weight: 23
menu_name: admin
parent: admin_toolbar_tools.add_content
enabled: true
expanded: false
_core:
default_config_hash: jdY7AU0tU-QsjmiOw3W8vwpYMb-By--_MSFgbqKUTYM
4 changes: 2 additions & 2 deletions config/sync/field.field.node.va_form.field_administration.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ dependencies:
- node.type.va_form
- taxonomy.vocabulary.administration
content:
- 'taxonomy_term:administration:40ef8d64-fa92-41b6-88c0-4d85dc24e191'
- 'taxonomy_term:administration:7d7e2e18-f91e-4af0-bca2-52a9af9a7b3e'
id: node.va_form.field_administration
field_name: field_administration
entity_type: node
Expand All @@ -18,7 +18,7 @@ required: true
translatable: true
default_value:
-
target_uuid: 40ef8d64-fa92-41b6-88c0-4d85dc24e191
target_uuid: 7d7e2e18-f91e-4af0-bca2-52a9af9a7b3e
default_value_callback: ''
settings:
handler: 'default:taxonomy_term'
Expand Down
8 changes: 8 additions & 0 deletions config/sync/metatag.metatag_defaults.node__va_form.yml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
uuid: 9ad568f4-ed58-46a7-809a-023aa60cf80d
langcode: en
status: true
dependencies: { }
id: node__va_form
label: 'Content: VA form'
tags:
description: '[node:field_va_form_usage:value]'
2 changes: 1 addition & 1 deletion config/sync/migrate_plus.migration.va_node_form.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ source:
constants:
administration_section: 196
idprefix: vha_
title_prefix: 'Va Form '
title_prefix: 'About VA Form '
process:
migrate/flags/deleted: Deleted
migrate/deleted_date: DeletedDate
Expand Down
2 changes: 2 additions & 0 deletions config/sync/views.view.va_forms.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ dependencies:
content:
- 'taxonomy_term:administration:2c331a6d-b525-4f0c-8bea-4ecde41c7ef0'
- 'taxonomy_term:administration:867e4dcf-2f99-401a-977a-adb441d53350'
- 'taxonomy_term:administration:c20f3989-e93e-49bd-8c95-ad3821042a02'
- 'taxonomy_term:administration:e5820ec7-83b0-4d03-8ebf-ed50fa8cc211'
- 'taxonomy_term:administration:edadc39e-dbaa-4fe1-b6a8-344357d6abfe'
module:
Expand Down Expand Up @@ -1148,6 +1149,7 @@ display:
admin_label: ''
operator: or
value:
5: 5
2: 2
1: 1
3: 3
Expand Down
2 changes: 1 addition & 1 deletion docroot/modules/custom/va_gov_migrate/config/install/migrate_plus.migration.va_node_form.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ source:
constants:
administration_section: 196
idprefix: vha_
title_prefix: 'Va Form '
title_prefix: 'About VA Form '
# All the fields that are used from the source.
# The destination fields mapped and processed from source fields.
process:
Expand Down

1 comment on commit 81deee5

@va-cms-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Test Failed: va/tests/accessibility 
composer va:test:accessibility
> [email protected] install /var/www/cms/node_modules/phantomjs-prebuilt
> node install.js

PhantomJS not found on PATH
Downloading https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2
Saving to /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
Receiving...

Received 22866K total.
Extracting tar contents (via spawned process)
Removing /var/www/cms/node_modules/phantomjs-prebuilt/lib/phantom
Copying extracted folder /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2-extract-1593025721431/phantomjs-2.1.1-linux-x86_64 -> /var/www/cms/node_modules/phantomjs-prebuilt/lib/phantom
Writing location.js file
Done. Phantomjs binary available at /var/www/cms/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs

> [email protected] postinstall /var/www/cms/node_modules/core-js
> node scripts/postinstall || echo "ignore"

Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!

The project needs your help! Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

added 134 packages from 190 contributors and audited 134 packages in 15.552s
found 3 low severity vulnerabilities
  run `npm audit fix` to fix them, or `npm audit` for details

> [email protected] test /var/www/cms
> node ./tests/accessibility/aXeAccessibilityCheck.js

!!!  NUMBER OF NEW VIOLATIONS on http://internal-dsva-vagov-staging-cms-1188006.us-gov-west-1.elb.amazonaws.com 1
!!!  NUMBER OF NEW VIOLATIONS on http://internal-dsva-vagov-staging-cms-1188006.us-gov-west-1.elb.amazonaws.com/sections  = 0
[]
!!!  NUMBER OF NEW VIOLATIONS on http://internal-dsva-vagov-staging-cms-1188006.us-gov-west-1.elb.amazonaws.com/node/add/page  = 2
[ { id: 'duplicate-id',
    impact: 'minor',
    tags: [ 'cat.parsing', 'wcag2a', 'wcag411' ],
    description: 'Ensures every id attribute value is unique',
    help: 'id attribute value must be unique',
    helpUrl:
     'https://dequeuniversity.com/rules/axe/3.3/duplicate-id?application=webdriverjs',
    nodes: [ [Object], [Object] ] },
  { id: 'label',
    impact: 'critical',
    tags:
     [ 'cat.forms',
       'wcag2a',
       'wcag332',
       'wcag131',
       'section508',
       'section508.22.n' ],
    description: 'Ensures every form element has a label',
    help: 'Form elements must have labels',
    helpUrl:
     'https://dequeuniversity.com/rules/axe/3.3/label?application=webdriverjs',
    nodes: [ [Object] ] } ]
!!!  NUMBER OF NEW VIOLATIONS on http://internal-dsva-vagov-staging-cms-1188006.us-gov-west-1.elb.amazonaws.com/node/add/landing_page  = 0
[]
!!!  NUMBER OF NEW VIOLATIONS on http://internal-dsva-vagov-staging-cms-1188006.us-gov-west-1.elb.amazonaws.com/node/add/documentation_page  = 1
[ { id: 'label',
    impact: 'critical',
    tags:
     [ 'cat.forms',
       'wcag2a',
       'wcag332',
       'wcag131',
       'section508',
       'section508.22.n' ],
    description: 'Ensures every form element has a label',
    help: 'Form elements must have labels',
    helpUrl:
     'https://dequeuniversity.com/rules/axe/3.3/label?application=webdriverjs',
    nodes: [ [Object] ] } ]
!!!  NUMBER OF NEW VIOLATIONS on http://internal-dsva-vagov-staging-cms-1188006.us-gov-west-1.elb.amazonaws.com/node/add/event  = 0
[]
!!!  NUMBER OF NEW VIOLATIONS on http://internal-dsva-vagov-staging-cms-1188006.us-gov-west-1.elb.amazonaws.com/node/add/health_care_local_facility  = 1
[ { id: 'label',
    impact: 'critical',
    tags:
     [ 'cat.forms',
       'wcag2a',
       'wcag332',
       'wcag131',
       'section508',
       'section508.22.n' ],
    description: 'Ensures every form element has a label',
    help: 'Form elements must have labels',
    helpUrl:
     'https://dequeuniversity.com/rules/axe/3.3/label?application=webdriverjs',
    nodes:
     [ [Object],
       [Object],
       [Object],
       [Object],
       [Object],
       [Object],
       [Object],
       [Object],
       [Object],
       [Object],
       [Object],
       [Object],
       [Object],
       [Object] ] } ]
!!!  NUMBER OF NEW VIOLATIONS on http://internal-dsva-vagov-staging-cms-1188006.us-gov-west-1.elb.amazonaws.com/node/add/health_care_region_detail_page  = 2
[ { id: 'duplicate-id',
    impact: 'minor',
    tags: [ 'cat.parsing', 'wcag2a', 'wcag411' ],
    description: 'Ensures every id attribute value is unique',
    help: 'id attribute value must be unique',
    helpUrl:
     'https://dequeuniversity.com/rules/axe/3.3/duplicate-id?application=webdriverjs',
    nodes: [ [Object], [Object] ] },
  { id: 'label',
    impact: 'critical',
    tags:
     [ 'cat.forms',
       'wcag2a',
       'wcag332',
       'wcag131',
       'section508',
       'section508.22.n' ],
    description: 'Ensures every form element has a label',
    help: 'Form elements must have labels',
    helpUrl:
     'https://dequeuniversity.com/rules/axe/3.3/label?application=webdriverjs',
    nodes: [ [Object] ] } ]
!!!  NUMBER OF NEW VIOLATIONS on http://internal-dsva-vagov-staging-cms-1188006.us-gov-west-1.elb.amazonaws.com/node/add/health_care_region_page  = 0
[]
!!!  NUMBER OF NEW VIOLATIONS on http://internal-dsva-vagov-staging-cms-1188006.us-gov-west-1.elb.amazonaws.com/node/add/office  = 0
[]
!!!  NUMBER OF NEW VIOLATIONS on http://internal-dsva-vagov-staging-cms-1188006.us-gov-west-1.elb.amazonaws.com/node/add/outreach_asset  = 0
[]
!!!  NUMBER OF NEW VIOLATIONS on http://internal-dsva-vagov-staging-cms-1188006.us-gov-west-1.elb.amazonaws.com/node/add/person_profile  = 0
[]
!!!  NUMBER OF NEW VIOLATIONS on http://internal-dsva-vagov-staging-cms-1188006.us-gov-west-1.elb.amazonaws.com/node/add/press_release  = 1
[ { id: 'aria-allowed-attr',
    impact: 'critical',
    tags: [ 'cat.aria', 'wcag2a', 'wcag412' ],
    description: 'Ensures ARIA attributes are allowed for an element\'s role',
    help: 'Elements must only use allowed ARIA attributes',
    helpUrl:
     'https://dequeuniversity.com/rules/axe/3.3/aria-allowed-attr?application=webdriverjs',
    nodes: [ [Object] ] } ]
!!!  NUMBER OF NEW VIOLATIONS on http://internal-dsva-vagov-staging-cms-1188006.us-gov-west-1.elb.amazonaws.com/node/add/regional_health_care_service_des  = 0
[]
!!!  NUMBER OF NEW VIOLATIONS on http://internal-dsva-vagov-staging-cms-1188006.us-gov-west-1.elb.amazonaws.com/node/add/news_story  = 0
[]
!!!  NUMBER OF NEW VIOLATIONS on http://internal-dsva-vagov-staging-cms-1188006.us-gov-west-1.elb.amazonaws.com/node/add/support_service  = 0
[]
!!!  NUMBER OF NEW VIOLATIONS on http://internal-dsva-vagov-staging-cms-1188006.us-gov-west-1.elb.amazonaws.com/user  = 1
[ { id: 'color-contrast',
    impact: 'serious',
    tags: [ 'cat.color', 'wcag2aa', 'wcag143' ],
    description:
     'Ensures the contrast between foreground and background colors meets WCAG 2 AA contrast ratio thresholds',
    help: 'Elements must have sufficient color contrast',
    helpUrl:
     'https://dequeuniversity.com/rules/axe/3.3/color-contrast?application=webdriverjs',
    nodes:
     [ [Object], [Object], [Object], [Object], [Object], [Object] ] } ]
!!!  VIOLATION TYPES FOUND: 9 PROCESS EXITED WITH CODE 1  !!!
> npm install --only=production
> npm test
Wed, 24 Jun 2020 19:08:46 GMT axe-webdriverjs deprecated Error must be handled as the first argument of axe.analyze. See: #83 at tests/accessibility/aXeAccessibilityCheck.js:45:14
Wed, 24 Jun 2020 19:08:53 GMT axe-webdriverjs deprecated Error must be handled as the first argument of axe.analyze. See: #83 at tests/accessibility/aXeAccessibilityCheck.js:57:42
npm ERR! Test failed.  See above for more details.
Script npm test handling the va:test:accessibility event returned with error code 1
  • On: ip-10-247-34-49
  • In: 02:30

Please sign in to comment.