AlecK/APPEALS-44509 - (6.1 Base) #1671
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcroteau
reviewed
Sep 5, 2024
Comment on lines
+1
to
+9
| # frozen_string_literal: true | ||
| require "rails_helper" | ||
|
|
||
| # See config/initializers/zeitwerk.rb if this fails | ||
| RSpec.describe "Zeitwerk Compliance Check" do | ||
| it "Eager loads all files without errors" do | ||
| expect { Rails.application.eager_load! }.not_to raise_error | ||
| end | ||
| end |
There was a problem hiding this comment.
For conformity w/ Caseflow, let's move this file to spec/config/zeitwerk_spec.rb.
jcroteau
reviewed
Sep 5, 2024
| config.autoload_paths += Dir[Rails.root + 'app/jobs'] | ||
| config.autoload_paths << Rails.root.join('lib') | ||
| config.autoload_paths << Rails.root.join('lib/scripts') | ||
|
|
There was a problem hiding this comment.
Let's move the Zeitwerk inflector settings here (before config.autoload_paths) and delete the initializer, as was done for Caseflow in this commit.
This is a precautionary move, to circumvent potential sequencing issues when autoloading inflected constants in the autoload_once_paths (via the once autoloader).
We are not currently autloading anything with the once autoloader, but if down the road we need to, this will be one less gotcha we'll have to deal with.
For more details on this issue, see rails/rails#45568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves AlecK/APPEALS-44509
Description
These are the changes necessary for eFolder to become Zeitwerk compliant.
Acceptance Criteria
bin/rails zeitwerk:check