Lint everything else #116
Lint everything else #116
Conversation
| @@ -47,18 +47,9 @@ | |||
| ], | |||
| "prettier": true, | |||
| "rules": { | |||
| "camelcase": "off", | |||
| "ava/no-import-test-files": "off", | |||
There was a problem hiding this comment.
| "prefer-spread": "off", | ||
| "unicorn/explicit-length-check": "off", | ||
| "unicorn/prevent-abbreviations": "off" | ||
| "camelcase": "off" |
There was a problem hiding this comment.
Due to GitHub’s API
denis-sokolov
force-pushed
the
lint-rest
branch
from
16477d7
to
427c7b9
Compare
| @@ -73,41 +73,43 @@ test.cb('should not delete a fork that has more branches', (t) => { | |||
| }); | |||
| }); | |||
|
|
|||
| // Currently our logic does not delete this fork | |||
| test.skip('should delete a fork that has more branches, but all at upstream branch tips', (t) => { | |||
There was a problem hiding this comment.
Hecks knows, I don’t remember why it works. Perhaps I had added the functionality afterwards and forgot to enable the test? Weird.
| test.cb( | ||
| 'should delete a fork that has more branches, but all at upstream branch tips', |
There was a problem hiding this comment.
eslint strangely formats this. If the test.cb part is anything other than test.skip, it puts arguments on separate lines. If it’s test.skip, then both arguments are on one line. That’s with ava/no-skip-test disabled.
At first I thought it’s due to the line length, but no, even in the PR diff the shorter version is wrapped, and the longer isn’t. And, also, test.ski is wrapped, and test.skipp is wrapped. Weird.
There was a problem hiding this comment.
That’s Prettier. Yeah I don’t like Prettier’s wrapping either 😉
XO doesn’t care about line length as long as there’s no more than one ; per line.
There was a problem hiding this comment.
You’re right that it’s prettier! prettier/prettier#9285
Manual lint of the last few rules