-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Seq)!: Add sequenceResultA, align sequenceResultM #255
Conversation
4a13d62
to
f23dd0e
Compare
Open to removing anything you consider an overstep - I'm not enjoying the fantomas ruleset so there is some letter of the law interpretations. Please push back on anything that's not right! have not actually fsi'd the doc samples, or looked at the gitbook |
93115e8
to
b8cab35
Compare
b8cab35
to
b254b92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ Thanks for this!. Left some feedback.
as mentioned in #254 I'm happy either way. Adding it is not time-sensitive for me, so I'll leave it entirely up to you whether you want I guess my slight preference is to stay with one PR, but I'm a maintainer too so I'd prefer you to make the call. |
99d629a
to
3b71915
Compare
3a5fe58
to
d088226
Compare
@@ -4,10 +4,12 @@ | |||
<OutputType>Exe</OutputType> | |||
<TargetFramework>net7.0</TargetFramework> | |||
<IsPackable>false</IsPackable> | |||
<!-- <NoWarn>NU1904</NoWarn>--> | |||
<TreatWarningsAsErrors>false</TreatWarningsAsErrors> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a new vulnerability that breaks the build
I see you have 1903 in the build props - if you fix that, I'l rebase off that as its obv not ideal to have this in the PR
The build wasn't happy for reasons I could not discern - happy to rebase or adjust this any time; just ping |
Implements #254
Seq.sequenceResultA
sequenceResultM
with that ofsequenceResultA
(yield an Array, rather than accumulating in alist
and upcasting viaList.toSeq
sequenceResultM