Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResultOption Updates #221

Merged

Conversation

1eyewonder
Copy link
Contributor

Proposed Changes

ResultOption functions

  • Updated functions to use generic constraints
  • Updated parameters to use InlineIfLambda attributes where applicable

ResultOption CE

  • Updated to have similar functionality as rest of CEs in order to provide users the most bang for their buck

Unit Tests

  • Created unit tests for the CE
  • I goofed on the previous few PRs by not adding the unit tests in FsToolkit.ErrorHandling.Tests to the Main.fs file. I tried making it so all tests are picked up in the assembly but as the comment that was previously there, the top level test list needs to be there for dotnet test to work ☹️

Types of changes

What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an x in the boxes that apply and remove ones that don't apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

@TheAngryByrd
Copy link
Collaborator

🎸

@TheAngryByrd TheAngryByrd merged commit ae36a76 into demystifyfp:master Jul 10, 2023
3 checks passed
TheAngryByrd added a commit that referenced this pull request Jul 10, 2023
- [ResultOption Updates](#221)
@1eyewonder 1eyewonder deleted the feature/resultOptionUpdates branch July 10, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants