Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mattermost v2: Added support for multiple notification types #36129

Merged
merged 14 commits into from
Sep 22, 2024

Conversation

MLainer1
Copy link
Contributor

@MLainer1 MLainer1 commented Sep 4, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Adding support for notifications

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Sep 4, 2024

@MLainer1 MLainer1 marked this pull request as ready for review September 9, 2024 10:21
Copy link
Contributor

@RotemAmit RotemAmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, will approve after our sync

@ShirleyDenkberg
Copy link
Contributor

@dantavori @RotemAmit Doc review completed.

Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving but see notes

@MLainer1 MLainer1 merged commit 69235d7 into master Sep 22, 2024
16 checks passed
@MLainer1 MLainer1 deleted the bug_mattermost_notifications_missing branch September 22, 2024 06:09
sharonfi99 pushed a commit that referenced this pull request Sep 29, 2024
* Mattermost v2: Added support for multiple notification types

* Added new parameter

* pc

* added test

* added test and pack_ignore

* cr

* pc

* small changes

* di + small changes

* pc

* cr

* cr
sharonfi99 pushed a commit that referenced this pull request Sep 29, 2024
* Mattermost v2: Added support for multiple notification types

* Added new parameter

* pc

* added test

* added test and pack_ignore

* cr

* pc

* small changes

* di + small changes

* pc

* cr

* cr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants