Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xsup 40686 rasterize #35957

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Xsup 40686 rasterize #35957

wants to merge 38 commits into from

Conversation

maimorag
Copy link
Contributor

@maimorag maimorag commented Aug 20, 2024

Related Issues

fixes: link to the issue, https://jira-dc.paloaltonetworks.com/browse/CIAC-11720

Description

Fixed an issue where using the rasterize command after reaching the max rasterize connections would return the error message "Could not use local Chrome for rasterize command., by moving the closing all connections to the chrome_manager function.

Copy link

github-actions bot commented Aug 20, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/rasterize/Integrations/rasterize
   rasterize.py4468381%67–69, 76–78, 84–86, 126, 141–143, 146–148, 151, 154–156, 160–162, 174–175, 179–180, 184–185, 206–208, 219, 250–251, 274, 286–293, 297–304, 321–323, 357–358, 363, 431–432, 435–438, 440, 759–761, 771–772, 775, 813–814, 832, 841, 843–845, 855, 862–865
TOTAL4468381% 

Tests Skipped Failures Errors Time
111 0 💤 3 ❌ 3 🔥 12m 30s ⏱️

Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
@maimorag maimorag marked this pull request as ready for review August 25, 2024 07:48
@@ -5,7 +5,7 @@ description: |-
Tests the scenario where similar phishing incidents should create a phishing campaign incident.
It does that by creating fake phishing incidents which should run the Phishing - Generic v3 playbook, and in the process run the Detect & Manage Phishing Campaigns playbook.

The campaign incident should have 9 incidents when all incidents have finished running.
The campaign incident should have 9 incidents when all incidents have finished running.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this playbook was changed so the playbook would run again

Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Approved from my side.
Great job.

Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ilaredo ilaredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great changes!
just few comments from my side

Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants