-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xsup 40686 rasterize #35957
base: master
Are you sure you want to change the base?
Xsup 40686 rasterize #35957
Conversation
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
@@ -5,7 +5,7 @@ description: |- | |||
Tests the scenario where similar phishing incidents should create a phishing campaign incident. | |||
It does that by creating fake phishing incidents which should run the Phishing - Generic v3 playbook, and in the process run the Detect & Manage Phishing Campaigns playbook. | |||
|
|||
The campaign incident should have 9 incidents when all incidents have finished running. | |||
The campaign incident should have 9 incidents when all incidents have finished running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this playbook was changed so the playbook would run again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Approved from my side.
Great job.
Co-authored-by: Yuval Hayun <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great changes!
just few comments from my side
Related Issues
fixes: link to the issue, https://jira-dc.paloaltonetworks.com/browse/CIAC-11720
Description
Fixed an issue where using the rasterize command after reaching the max rasterize connections would return the error message "Could not use local Chrome for rasterize command., by moving the closing all connections to the chrome_manager function.