Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: refactor and rocksdb implementation #123
base: main
Are you sure you want to change the base?
storage: refactor and rocksdb implementation #123
Changes from all commits
4e2feea
8660bf0
263df98
f78b7c0
835393f
af621a1
8d9c2f6
8ba536d
b4f0a84
012fa5b
2aed85f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets run cargo-udeps on this PR to see which deps we can remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle potential serialization errors to prevent panics
Using
unwrap()
on the result ofbincode::serialize
can cause a panic if serialization fails. It's better to handle this error to prevent unexpected crashes and improve the robustness of the code.Apply this diff to handle the error:
Alternatively, if the function returns a
Result
, you can use the?
operator:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create an issue for this? It needs to be fixed but not in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@distractedm1nd, the GitHub issue has been created successfully: Issue #127.
Analysis chain
@distractedm1nd, I'll create an issue to track this.
@distractedm1nd, thanks for pointing out the issue. The error occurs because backticks in the shell script are interpreted as command substitutions. Here's the corrected script with escaped backticks:
Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 1147
Script:
Length of output: 758