Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preflight checks #272

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix preflight checks #272

merged 1 commit into from
Apr 18, 2024

Conversation

panigs7
Copy link
Contributor

@panigs7 panigs7 commented Apr 18, 2024

Description

This PR fixes the HasLicense check failure in the preflight scans for csm-authorization-sidecar image in RedHat portal. This is necessary for RedHat to publish authorization sidecar image in its catalog

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Preflight checks passes:
image

@csmbot
Copy link
Collaborator

csmbot commented Apr 18, 2024

Can one of the admins verify this patch?

@shaynafinocchiaro
Copy link
Collaborator

e2e pass

@shaynafinocchiaro shaynafinocchiaro merged commit ff25097 into main Apr 18, 2024
8 checks passed
@shaynafinocchiaro shaynafinocchiaro deleted the fix-preflight-checks branch April 18, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants