add storage password prompt (#284)

cmd/karavictl/cmd/storage_create.go

@@ -23,6 +23,7 @@ import (
 	"karavi-authorization/internal/web"
 	"karavi-authorization/pb"
 	"net/http"
+	"net/url"
 	"strings"
 	"syscall"
 
@@ -142,6 +143,18 @@ func NewStorageCreateCmd() *cobra.Command {
 				Access:  accessToken,
 			}
 
+			urlWithUser, err := url.Parse(input.Endpoint)
+			if err != nil {
+				errAndExit(err)
+			}
+
+			urlWithUser.Scheme = "https"
+			urlWithUser.User = url.User(input.User)
+
+			if !cmd.Flags().Lookup("password").Changed {
+				readPassword(cmd.ErrOrStderr(), fmt.Sprintf("Enter password for %v: ", urlWithUser), &input.Password)
+			}
+
 			if err := doStorageCreateRequest(context.Background(), addr, input, insecure, cmd, adminTknBody); err != nil {
 				reportErrorAndExit(JSONOutput, cmd.ErrOrStderr(), fmt.Errorf(outFormat, err))
 			}

cmd/karavictl/cmd/storage_create_test.go

@@ -22,6 +22,7 @@ import (
 	"io"
 	"karavi-authorization/cmd/karavictl/cmd/api"
 	"karavi-authorization/cmd/karavictl/cmd/api/mocks"
+	"karavi-authorization/pb"
 	"net/url"
 	"os"
 	"testing"
@@ -82,6 +83,7 @@ func TestStorageCreateHandler(t *testing.T) {
 		JSONOutput = jsonOutput
 		osExit = os.Exit
 		ReadAccessAdminToken = readAccessAdminToken
+		termReadPassword = term.ReadPassword
 	}
 
 	t.Run("it requests creation of a storage", func(t *testing.T) {
@@ -114,6 +116,51 @@ func TestStorageCreateHandler(t *testing.T) {
 			t.Error("expected Create to be called, but it wasn't")
 		}
 	})
+	t.Run("it requests creation of a storage without the password flag", func(t *testing.T) {
+		defer afterFn()
+		termReadPassword = func(_ int) ([]byte, error) {
+			return []byte("password"), nil
+		}
+
+		var gotCalled bool
+		var gotPassword string
+		CreateHTTPClient = func(_ string, _ bool) (api.Client, error) {
+			return &mocks.FakeClient{
+				PostFn: func(_ context.Context, _ string, _ map[string]string, _ url.Values, body interface{}, _ interface{}) error {
+					gotCalled = true
+					storageCreateRequest, ok := body.(**pb.StorageCreateRequest)
+					if !ok {
+						t.Fatalf("unexpected type %T for request body", body)
+					}
+					gotPassword = (*storageCreateRequest).Password
+					return nil
+				},
+			}, nil
+		}
+		ReadAccessAdminToken = func(_ string) (string, string, error) {
+			return "AUnumberTokenIsNotWorkingman", "AUnumberTokenIsNotWorkingman", nil
+		}
+		JSONOutput = func(_ io.Writer, _ interface{}) error {
+			return nil
+		}
+		osExit = func(_ int) {
+		}
+		var gotOutput bytes.Buffer
+
+		cmd := NewRootCmd()
+		cmd.SetOutput(&gotOutput)
+		cmd.SetIn(bytes.NewBufferString("password"))
+		cmd.SetArgs([]string{"storage", "create", "--endpoint", "https://0.0.0.0:443", "--system-id", "testing123", "--type", "powerflex", "--user", "admin", "--insecure", "--array-insecure", "--admin-token", "admin.yaml", "--addr", "proxy.com"})
+		cmd.Execute()
+
+		if !gotCalled {
+			t.Error("expected Create to be called, but it wasn't")
+		}
+
+		if gotPassword != "password" {
+			t.Errorf("expected password %s, got %s", "password", gotPassword)
+		}
+	})
 	t.Run("it requires a valid storage server connection", func(t *testing.T) {
 		defer afterFn()
 		CreateHTTPClient = func(_ string, _ bool) (api.Client, error) {