Call reusable action for go version updates (#296)

* Create go-version.yaml

* Update linters.yaml

* gosec and linting

* gosec

.github/workflows/go-version.yaml

@@ -0,0 +1,22 @@
+# Copyright (c) 2024 Dell Inc., or its subsidiaries. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+
+# Reusable workflow to perform go version update on Golang based projects
+name: Go Version Update
+
+on:
+  workflow_dispatch:
+  repository_dispatch:
+    types: [go-update-workflow]
+
+jobs:
+  # go version update
+  go-version-update:
+    uses: dell/common-github-actions/.github/workflows/go-version-workflow.yaml@main
+    name: Go Version Update
+    secrets: inherit

.github/workflows/linters.yaml

@@ -24,7 +24,7 @@ jobs:
         run: |
           go mod vendor
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v5
+        uses: golangci/golangci-lint-action@v6
         with:
           version: latest
           skip-cache: true

cmd/karavictl/cmd/role.go

@@ -146,9 +146,6 @@ func GetRoles() (*roles.JSON, error) {
 	}
 
 	rolesRego := dataField.Data["common.rego"]
-	if err != nil {
-		return nil, err
-	}
 
 	rolesJSON := strings.Replace(rolesRego, "package karavi.common\ndefault roles = {}\nroles = ", "", 1)
 
@@ -207,7 +204,7 @@ func validatePowerFlexPool(storageSystemDetails System, storageSystemID string,
 		return err
 	}
 
-	if int(poolQuota.Quota) < 0 {
+	if poolQuota.Quota < 0 {
 		return errors.New("the specified quota needs to be a positive number")
 	}
 	return nil
@@ -237,7 +234,7 @@ func validatePowerMaxStorageResourcePool(ctx context.Context, storageSystemDetai
 		return err
 	}
 
-	if int(poolQuota.Quota) < 0 {
+	if poolQuota.Quota < 0 {
 		return errors.New("the specified quota needs to be a positive number")
 	}
 	return nil
@@ -260,7 +257,7 @@ func validatePowerScaleIsiPath(storageSystemDetails System, _ string, poolQuota
 		return err
 	}
 
-	if int(poolQuota.Quota) != 0 {
+	if poolQuota.Quota != 0 {
 		return errors.New("quota must be 0 as it is not enforced by CSM-Authorization")
 	}
 

cmd/karavictl/cmd/storage_create.go

@@ -184,7 +184,7 @@ func NewStorageCreateCmd() *cobra.Command {
 }
 
 func readPassword(w io.Writer, prompt string, p *string) {
-	fmt.Fprintf(w, prompt)
+	fmt.Fprintf(w, "%s", prompt)
 	b, err := termReadPassword(int(syscall.Stdin))
 	if err != nil {
 		reportErrorAndExit(JSONOutput, w, err)