Skip to content

Commit

Permalink
gosec fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
suryagupta4 committed Jul 19, 2024
1 parent 70ff0f7 commit fea5f78
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions gonvme_tcp_fc.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,14 +100,16 @@ func (nvme *NVMe) getFCHostInfo() ([]FCHBAInfo, error) {
for _, m := range match {

var FCHostInfo FCHBAInfo
data, err := os.ReadFile(path.Join(m, "port_name"))
portNamePath := path.Join(m, "port_name")
data, err := os.ReadFile(filepath.Clean(portNamePath))
if err != nil {
log.Errorf("match: %s failed to read port_name file: %s", match, err.Error())
continue
}
FCHostInfo.PortName = strings.TrimSpace(string(data))

data, err = os.ReadFile(path.Join(m, "node_name"))
nodeNamePath := path.Join(m, "node_name")
data, err = os.ReadFile(filepath.Clean(nodeNamePath))
if err != nil {
log.Errorf("match: %s failed to read node_name file: %s", match, err.Error())
continue
Expand Down Expand Up @@ -426,7 +428,7 @@ func (nvme *NVMe) getInitiators(filename string) ([]string, error) {
}

// get the contents of the initiator config file
out, err := os.ReadFile(init)
out, err := os.ReadFile(filepath.Clean(init))
if err != nil {
log.Errorf("Error gathering initiator names: %v", err)
}
Expand Down

0 comments on commit fea5f78

Please sign in to comment.