Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build and release process #119

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ianmjones
Copy link
Member

@ianmjones ianmjones commented Oct 18, 2024

Resolves DELI-1149

Things done:

  • Minified CSS and JS assets are no longer stored in git, and have been added to .gitignore.
  • Minified CSS and JS assets are now only generated when their source is touched or the minified asset is missing.
  • The pot language file is only regenerated when PHP source is touched.
  • If the node_modules directory is missing, it is automatically created via yarn install when any kind of make target that requires grunt is referenced.
  • Running make on its own now builds any assets or updates the pot file as necessary.
  • Running make package or make zip are still available, and still effectively do the same thing.
  • A make clean target has been added to remove any ephemeral assets or build files.
  • A make clean-all target has been added does the same as clean but also remove node_modules.
  • The package-lock.json file that is not needed as we use yarn has been removed.
  • The package.json file's version entry has been updated to stay in sync with the current version of the plugin.
  • The old out of date README.md has been removed, the always up to date README.txt will suffice for now (we may add a less likely to go out of date README.md in the future).

@ianmjones ianmjones requested a review from philwp October 18, 2024 14:44
@ianmjones ianmjones requested a review from a team as a code owner October 18, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant