Feat/feature flags #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… only using renWBTC pool
atvanguard
reviewed
Nov 15, 2021
contracts/peaks/BadgerSettPeak.sol
Outdated
|
|
||
| import {ISwap} from "../interfaces/ISwap.sol"; | ||
| import {ICore} from "../interfaces/ICore.sol"; | ||
| import {ISett} from "../interfaces/ISett.sol"; | ||
| import {IBadgerSettPeak} from "../interfaces/IPeak.sol"; | ||
|
|
||
| contract BadgerSettPeak is AccessControlDefended, IBadgerSettPeak { | ||
| contract BadgerSettPeak is AccessControlDefended, Pausable, IBadgerSettPeak { |
There was a problem hiding this comment.
Need to use PausableSlot.sol
contracts/peaks/BadgerSettPeak.sol
Outdated
Comment on lines
47
to
61
| modifier onlyGuardianOrGovernance() { | ||
| require(msg.sender == guardian || msg.sender == owner(), "onlyGuardianOrGovernance"); | ||
| _; | ||
| } | ||
|
|
||
| // ===== Pausing Functionality ===== | ||
|
|
||
| function pause() external onlyGuardianOrGovernance { | ||
| _pause(); | ||
| } | ||
|
|
||
| function unpause() external onlyGovernance { | ||
| _unpause(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Would prefer these be moved to AccessControlDefended to avoid code duplication across peaks.
contracts/peaks/BadgerSettPeak.sol
Outdated
| @@ -186,6 +206,10 @@ contract BadgerSettPeak is AccessControlDefended, IBadgerSettPeak { | |||
| onlyGovernance | |||
| { | |||
| CurvePool memory pool; | |||
|
|
|||
| // We only will support one asset per peak going forward. While somewhat hacky, this allows us to preserve the interface and existing code. | |||
| require(_pools.length <= 1, "maximum of one whitelisted pool"); | |||
There was a problem hiding this comment.
Discussed on DM, that this doesn't solve anything.
atvanguard
reviewed
Nov 17, 2021
| @@ -32,7 +32,7 @@ contract AccessControlDefendedBase { | |||
| } | |||
|
|
|||
| contract AccessControlDefended is GovernableProxy, AccessControlDefendedBase { | |||
| uint256[50] private __gap; | |||
| uint256[48] private __gap; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.