Refactor and Optimize: Function Encapsulation and Dynamic Scheduling Enhancements in Grid Integration Module #4403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanchen
approved these changes
Jun 17, 2024
mohanchen
changed the title
dyzheng
requested changes
Jun 18, 2024
| auto iter = sparseMatrix.find(R_coor); | ||
| if (iter != sparseMatrix.end()) | ||
| { | ||
| if (trace_lo[row] >= 0) // 使用类成员变量 trace_lo |
There was a problem hiding this comment.
Please use English for comments.
|
|
||
| }; | ||
|
|
||
|
|
||
| inline void Gint_k::process_sparse_matrix( |
There was a problem hiding this comment.
Please don't add function with definition in *.h, you can move it to *.hpp.
|
Since the class is over, I will close this PR. New PR is welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process_sparse_matrix.process_sparse_matrixfunction now supports both general sparse matrix processing and specificdim-based distribution.