follow advice from review

deepmodeling · May 27, 2024 · 2da945a · 2da945a
1 parent bcacb4a
commit 2da945a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/source/module_basis/module_ao/parallel_2d.cpp b/source/module_basis/module_ao/parallel_2d.cpp
@@ -1,6 +1,7 @@
 #include "parallel_2d.h"
 
 #include <numeric>
+#include <cassert>
 
 #include "module_base/blacs_connector.h"
 #include "module_base/scalapack_connector.h"
@@ -107,6 +108,8 @@ int Parallel_2D::set(
 
 void Parallel_2D::set_serial(const int mg, const int ng)
 {
+    assert(mg > 0 && ng > 0);
+
     nb = 1;
     dim0 = dim1 = 1;
     coord[0] = coord[1] = 0;

diff --git a/source/module_basis/module_ao/parallel_2d.h b/source/module_basis/module_ao/parallel_2d.h
@@ -114,7 +114,6 @@ class Parallel_2D
     /// map from local index to global index
     std::vector<int> local2global_row_;
     std::vector<int> local2global_col_;
-    // Peize Lin change int* to vector 2022.08.03
 
 #ifdef __MPI
     void _init_proc_grid(const MPI_Comm comm, const bool mode);