Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Fixes QaServingTranslator output format #3500

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 58.91%. Comparing base (b6656ed) to head (ee2ecb3).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...l/modality/nlp/translator/QaServingTranslator.java 40.00% 6 Missing ⚠️
...anslator/TokenClassificationServingTranslator.java 0.00% 1 Missing ⚠️
...rc/main/java/ai/djl/ndarray/BytesSupplierImpl.java 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #3500       +/-   ##
=============================================
- Coverage     72.52%   58.91%   -13.62%     
+ Complexity     7394     5856     -1538     
=============================================
  Files           672      674        +2     
  Lines         32909    33042      +133     
  Branches       3501     3523       +22     
=============================================
- Hits          23868    19467     -4401     
- Misses         7400    12093     +4693     
+ Partials       1641     1482      -159     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachgk zachgk merged commit 187e440 into deepjavalibrary:master Oct 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants