feat: allow overflow by default on ui.panel #896
+187
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
previously approved these changes
Sep 20, 2024
mattrunyon
requested changes
Sep 20, 2024
Comment on lines
+183
to
+189
| // classes can be used for deephaven ui specific css | ||
| // "deephaven.ui.components.Grid" -> "dh-grid" | ||
| if (shouldAddClassName.has(newElement[ELEMENT_KEY])) { | ||
| props.UNSAFE_className = `${props.UNSAFE_className ?? ''} ${`dh-${ | ||
| newElement[ELEMENT_KEY].split('.').pop()?.toLowerCase() ?? '' | ||
| }`}`.trim(); | ||
| } |
There was a problem hiding this comment.
I think we should just make Grid.tsx and Flex.tsx components instead that handle this
The shouldWrapTextChildren also probably belongs in wrapper components instead of this file. There's not really any reason we should be doing any manipulation here IMO. It hides what actually happens with the components
The contextualHelp is an exception I guess since we're wanting any prop called contextualHelp to be modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178
This improves the default layout experience across a number of layout cases. The primary goal was to allow overflow auto to happen on ui.panel by default while still filling space when passing multiple objects such as tables and plots.
Tested across the cases in ui_flex.py, added e2e tests for those cases.
Changes are as follows:
BREAKING CHANGE: ui.panel now has overflow auto set by default and ui.grid now has default padding