feat: ui.progress_bar and ui.progress_circle #892

wusteven815 · 2024-09-17T17:45:05Z

Adds ui.progress_circle and ui.progress_bar #826
Adds docs: ui.progress_bar #871
Adds docs: ui.progress_circle #872

vbabich · 2024-09-19T13:50:37Z

Approved js changes, haven't looked at python.

mofojed · 2024-09-19T14:34:06Z

@wusteven815 include docs for these as well. We should be adding docs for every new component we add. Will close #871 and #872 as well.
Something similar to https://react-spectrum.adobe.com/react-spectrum/ProgressCircle.html in our existing docs format (e.g. image.md)

mofojed

Add docs

Added

plugins/ui/docs/components/progress_bar.md

plugins/ui/docs/components/progress_circle.md

mofojed · 2024-09-20T19:06:02Z

plugins/ui/src/deephaven/ui/components/progress_bar.py

+    label_position: LabelPosition = "top",
+    show_value_label: bool | None = None,
+    label: Element | None = None,
+    # format_options, # omitted because need to connect it to Deephaven formatting options as well


@ethanalvizo is adding this to number_field right now, can add it to progress_bar when he's done that.

plugins/ui/docs/components/progress_bar.md

Added

dsmmcken

Every example should be standalone runnable, therefor needs import statements.

plugins/ui/docs/components/progress_circle.md

plugins/ui/docs/components/progress_bar.md

[0.0.2](https://pypi.org/project/deephaven-plugin-utilities/0.0.2/) is released

Co-authored-by: margaretkennedy <[email protected]>

- Fixes deephaven#731 - Extract and save `key` prop - Modify key generation to use the `key` prop if it exists - Allow `map` to be a valid component - Converts directly to a list while checking for unique props

- Fixes deephaven#744 - Update props types to convert `renderEmptyState` from `Element` in Python to `() => Element` in TypeScript - Throw error if `children` is undefined

Upgrades and centralizes the Vite version since we want to use the same version across all plugins

Closes deephaven#763 --------- Co-authored-by: margaretkennedy <[email protected]>

- Fixes deephaven#900 - Add missing `await`s

Co-authored-by: Don <[email protected]>

Added

plugins/ui/docs/components/progress_bar.md

Co-authored-by: Don <[email protected]>

jnumainville

Only reviewed the documentation and python. Mostly minor details.

plugins/ui/docs/components/progress_bar.md

jnumainville · 2024-10-02T15:56:21Z

plugins/ui/docs/components/progress_circle.md

@@ -0,0 +1,112 @@
+# Progress Circle
+
+Progress circles show the progression of a system operation such as downloading, uploading, or processing, in a visual way. They can represent determinate or indeterminate progress.


Is there any differentiation that should be made when picking between progres_bar and progress_circle or are they completely interchangeable?

I don't think so, React Spectrum doesn't say anything either

plugins/ui/docs/components/progress_circle.md

plugins/ui/src/deephaven/ui/components/progress_bar.py

Added

add progress bar and circle

eb80fa8

wusteven815 self-assigned this Sep 17, 2024

wusteven815 linked an issue Sep 17, 2024 that may be closed by this pull request

ui.progress_circle and ui.progress_bar #826

Closed

wusteven815 force-pushed the 826-progress-bar-circle branch from 24b005d to eb80fa8 Compare September 18, 2024 14:11

reorder import

af92dd3

wusteven815 marked this pull request as ready for review September 18, 2024 14:28

wusteven815 requested review from a team, vbabich and jnumainville and removed request for a team September 18, 2024 14:28

vbabich previously approved these changes Sep 19, 2024

View reviewed changes

mofojed previously requested changes Sep 19, 2024

View reviewed changes

wusteven815 dismissed vbabich’s stale review via cb972df September 19, 2024 18:58

github-actions bot requested a review from margaretkennedy September 19, 2024 18:58

This was linked to issues Sep 19, 2024

docs: ui.progress_bar #871

Closed

docs: ui.progress_circle #872

Closed

margaretkennedy reviewed Sep 20, 2024

View reviewed changes

wusteven815 requested a review from margaretkennedy September 20, 2024 16:26

mofojed previously approved these changes Sep 20, 2024

View reviewed changes

dsmmcken previously requested changes Sep 20, 2024

View reviewed changes

plugins/ui/docs/components/progress_bar.md Outdated Show resolved Hide resolved

wusteven815 dismissed mofojed’s stale review via e949f24 September 23, 2024 15:41

wusteven815 requested a review from dsmmcken September 23, 2024 15:51

dsmmcken previously requested changes Sep 24, 2024

View reviewed changes

build: Post version update for utilities (deephaven#886)

bad4227

[0.0.2](https://pypi.org/project/deephaven-plugin-utilities/0.0.2/) is released

wusteven815 and others added 9 commits September 24, 2024 15:58

add return type

e34ad14

update docs from review

785efb0

Co-authored-by: margaretkennedy <[email protected]>

fix: allows keys to be set in props (deephaven#810)

15262dd

- Fixes deephaven#731 - Extract and save `key` prop - Modify key generation to use the `key` prop if it exists - Allow `map` to be a valid component - Converts directly to a list while checking for unique props

fix: empty list view (deephaven#828)

b780b27

- Fixes deephaven#744 - Update props types to convert `renderEmptyState` from `Element` in Python to `() => Element` in TypeScript - Throw error if `children` is undefined

build: Upgrade to Vite 5 (deephaven#899)

23bcd52

Upgrades and centralizes the Vite version since we want to use the same version across all plugins

feat: Time Field UI Component (deephaven#825)

cf3f463

Closes deephaven#763 --------- Co-authored-by: margaretkennedy <[email protected]>

test: fix flaky key tests (deephaven#901)

9b95ac2

- Fixes deephaven#900 - Add missing `await`s

add key prop

fdf710b

update docs

a9e1d21

wusteven815 force-pushed the 826-progress-bar-circle branch from 7c371e1 to 1c46f92 Compare September 24, 2024 20:01

update docs from review

2d5f692

Co-authored-by: Don <[email protected]>

wusteven815 force-pushed the 826-progress-bar-circle branch from 1c46f92 to 2d5f692 Compare September 24, 2024 20:03

Merge branch 'deephaven:main' into 826-progress-bar-circle

113a6fc

wusteven815 requested a review from dsmmcken September 26, 2024 13:26

dsmmcken reviewed Sep 30, 2024

View reviewed changes

plugins/ui/docs/components/progress_bar.md Outdated Show resolved Hide resolved

wusteven815 and others added 2 commits October 1, 2024 11:38

Merge branch 'deephaven:main' into 826-progress-bar-circle

ece6c75

update docs from review

a82c111

Co-authored-by: Don <[email protected]>

jnumainville previously requested changes Oct 2, 2024

View reviewed changes

jnumainville mentioned this pull request Oct 2, 2024

feat: UI Calendar Component #918

Merged

update docs from review

22ce47b

wusteven815 requested review from dsmmcken and jnumainville October 4, 2024 13:58

dsmmcken approved these changes Oct 4, 2024

View reviewed changes

wusteven815 changed the title ~~feat: progress_bar and progress_circle~~ feat: ui.progress_bar and ui.progress_circle Oct 4, 2024

wusteven815 requested a review from vbabich October 4, 2024 21:11

jnumainville approved these changes Oct 4, 2024

View reviewed changes

wusteven815 merged commit 1ea206e into deephaven:main Oct 4, 2024
18 checks passed

wusteven815 deleted the 826-progress-bar-circle branch October 21, 2024 13:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ui.progress_bar and ui.progress_circle #892

feat: ui.progress_bar and ui.progress_circle #892

wusteven815 commented Sep 17, 2024 •

edited

Loading

vbabich commented Sep 19, 2024

mofojed commented Sep 19, 2024

mofojed left a comment

mofojed Sep 20, 2024

dsmmcken left a comment

jnumainville left a comment

jnumainville Oct 2, 2024

wusteven815 Oct 4, 2024

		@@ -0,0 +1,112 @@
		# Progress Circle

		Progress circles show the progression of a system operation such as downloading, uploading, or processing, in a visual way. They can represent determinate or indeterminate progress.

feat: ui.progress_bar and ui.progress_circle #892

feat: ui.progress_bar and ui.progress_circle #892

Conversation

wusteven815 commented Sep 17, 2024 • edited Loading

vbabich commented Sep 19, 2024

mofojed commented Sep 19, 2024

mofojed left a comment

Choose a reason for hiding this comment

mofojed Sep 20, 2024

Choose a reason for hiding this comment

dsmmcken left a comment

Choose a reason for hiding this comment

jnumainville left a comment

Choose a reason for hiding this comment

jnumainville Oct 2, 2024

Choose a reason for hiding this comment

wusteven815 Oct 4, 2024

Choose a reason for hiding this comment

wusteven815 commented Sep 17, 2024 •

edited

Loading