-
Notifications
You must be signed in to change notification settings - Fork 15
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Export plotly-express as a dashboard plugin (#329)
Tested with DHE V+ (1.20231218.176) Core 0.32.1 Closes #308 BREAKING CHANGE: - `widget` type in the `PanelEvent.OPEN` event arguments has changed from `VariableDefinition` to `VariableDescriptor`
- Loading branch information
Showing
3 changed files
with
89 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
import { useCallback, DragEvent, useEffect } from 'react'; | ||
import shortid from 'shortid'; | ||
import { | ||
DashboardPluginComponentProps, | ||
LayoutUtils, | ||
PanelEvent, | ||
useListener, | ||
} from '@deephaven/dashboard'; | ||
import type { VariableDescriptor } from '@deephaven/jsapi-types'; | ||
import PlotlyExpressChartPanel from './PlotlyExpressChartPanel.js'; | ||
import type { PlotlyChartWidget } from './PlotlyExpressChartUtils.js'; | ||
|
||
export function DashboardPlugin( | ||
props: DashboardPluginComponentProps | ||
): JSX.Element | null { | ||
const { id, layout, registerComponent } = props; | ||
|
||
const handlePanelOpen = useCallback( | ||
async ({ | ||
dragEvent, | ||
fetch, | ||
metadata = {}, | ||
panelId = shortid.generate(), | ||
widget, | ||
}: { | ||
dragEvent?: DragEvent; | ||
fetch: () => Promise<PlotlyChartWidget>; | ||
metadata?: Record<string, unknown>; | ||
panelId?: string; | ||
widget: VariableDescriptor; | ||
}) => { | ||
const { type, name } = widget; | ||
if (type !== 'deephaven.plot.express.DeephavenFigure') { | ||
return; | ||
} | ||
|
||
const config = { | ||
type: 'react-component' as const, | ||
component: 'PlotlyPanel', | ||
props: { | ||
localDashboardId: id, | ||
id: panelId, | ||
metadata: { | ||
...metadata, | ||
...widget, | ||
figure: name, | ||
}, | ||
fetch, | ||
}, | ||
title: name, | ||
id: panelId, | ||
}; | ||
|
||
const { root } = layout; | ||
LayoutUtils.openComponent({ root, config, dragEvent }); | ||
}, | ||
[id, layout] | ||
); | ||
|
||
useEffect( | ||
function registerComponentsAndReturnCleanup() { | ||
const cleanups = [ | ||
registerComponent('PlotlyPanel', PlotlyExpressChartPanel), | ||
]; | ||
return () => { | ||
cleanups.forEach(cleanup => cleanup()); | ||
}; | ||
}, | ||
[registerComponent] | ||
); | ||
|
||
useListener(layout.eventHub, PanelEvent.OPEN, handlePanelOpen); | ||
|
||
return null; | ||
} | ||
|
||
export default DashboardPlugin; |
11 changes: 10 additions & 1 deletion
11
plugins/plotly-express/src/js/src/PlotlyExpressChartUtils.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters