refactor: make utility classes UnboxTransform and ToChunkTypeTransform public #6338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcferretti
added
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
reviewed
Nov 6, 2024
Util/function/build.gradle
Outdated
| @@ -5,6 +5,8 @@ plugins { | |||
|
|
|||
| dependencies { | |||
| api project(':qst-type') | |||
| api project(':engine-query-constants') | |||
| api project(':engine-time') | |||
There was a problem hiding this comment.
I don't like this dependency on engine-time, given it is a bit more sprawling. Does ToChunkTypeTransform living in engine-time work for you?
There was a problem hiding this comment.
I think that should work, yes
jcferretti
changed the title
devinrsmith
reviewed
Nov 6, 2024
| @@ -1,13 +1,9 @@ | |||
| // | |||
| // Copyright (c) 2016-2024 Deephaven Data Labs and Patent Pending | |||
| // | |||
| package io.deephaven.kafka; | |||
| package io.deephaven.protobuf; | |||
There was a problem hiding this comment.
This is not really an appropriate package for it, at least publicly (I also claim that io.deephaven.kafka is not appropriate, but in that case it was internal only).
That said, I'm okay putting it into extensions-protobuf, but using a more appropriate package; io.deephaven.function; this sort of implies that we can continue to refactor it later to a more appropriate place if necessary.
devinrsmith
requested changes
Nov 6, 2024
devinrsmith
approved these changes
Nov 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.