fix: JS charts should handle shifts, read subscription data by key #6076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only viewport subscriptions should read data (and formatting) by position. Also fixes an error where -1 was not returned when an invalid position was checked in a RangeSet. Fixes deephaven#6074
niloc132
added
jsapi
plotting
NoDocumentationNeeded
ReleaseNotesNeeded
| .allMatch(arr -> arr.length == indexes.length); | ||
| assert cachedData.values().stream().flatMap(m -> m.values().stream()).allMatch(arr -> arr | ||
| .reduce((Object val, Any p1, int p2) -> ((Integer) val) + 1, 0) == indexes.length); | ||
| // then adds |
There was a problem hiding this comment.
isn't this where you should apply shifts?
There was a problem hiding this comment.
(discussed on videocall) This implementation doesn't care about shifts - the rowSet provided by the subscription is already correctly shifted, we just need to splice the values into the (flat) array so that downstream charting can ingest those arrays directly.
nbauernfeind
approved these changes
Sep 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only viewport subscriptions should read data (and formatting) by
position. Also fixes an error where -1 was not returned when an invalid
position was checked in a RangeSet.
Fixes #6074
Fixes #2435