feat: [WIP] Barrage Refactor Read/Write Chunk Factories and Default Type Mappings #6065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
barrage
core
nbauernfeind
force-pushed
the
barrage_types
branch
from
a6ad4c9
to
c4e970d
Compare
nbauernfeind
force-pushed
the
barrage_types
branch
from
c4e970d
to
28b25d1
Compare
rcaudy
reviewed
Sep 16, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/ReinterpretUtils.java
Show resolved
Hide resolved
| @@ -18,7 +20,56 @@ | |||
| /** | |||
| * Consumes Flight/Barrage streams and transforms them into WritableChunks. | |||
| */ | |||
| public interface ChunkReader { | |||
| public interface ChunkReader<ReadChunkType extends WritableChunk<Values>> { | |||
There was a problem hiding this comment.
We wondered if you could make the bound looser, e.g. PoolableChunk or SafeCloseable. Looks like maybe not? Should PoolableChunk be a Chunk (it's not right now)?
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/ChunkReader.java
Outdated
Show resolved
Hide resolved
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/DefaultChunkWriterFactory.java
Show resolved
Hide resolved
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/DefaultChunkWriterFactory.java
Outdated
Show resolved
Hide resolved
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/DefaultChunkWriterFactory.java
Show resolved
Hide resolved
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/DefaultChunkWriterFactory.java
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| private static long factorForTimeUnit(final TimeUnit unit) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58 (custom type serialization / deserialization).
Fixes #936 (ColumnConversionModes is being replaced with easy to integrate codecs).
Fixes #2984 (refactoring has good interface documentation).
Fixes #3403 (by supporting a variety of mappings, these now must match client wiring).
Fixes #4533 (java barrage client do put support).
Fixes #5258 (snapshot/subscribe methods with default w2w options).
Fixes #5453 (support other Timestamp arrow wire encodings).
Fixes #5864 (support for uint64_t).
Fixes #5969 (supports custom wire mappings).
This PR adds support to (some to be implemented as this is a WIP):