Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added additional jetty configuration options #6043

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

niloc132
Copy link
Member

@niloc132 niloc132 commented Sep 10, 2024

Deployments can now specify max h2 streams per connection and max request header size.

Set the configuration property http2.maxConcurrentStreams to the number of streams to allow for a given h2 connection.

Set the configuration property http.maxHeaderRequestSize to the max number of bytes to allow in HTTP request headers.

Fixes #5934
Fixes #6021

Deployments can now specify max h2 streams per connection and max
request header size.

Fixes deephaven#5934
Fixes deephaven#6021
Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Please update the description / merge message with the config property names.

Do we know if there is a technical reason why jetty uses the "low" default of 128 for maxConcurrentStreams? We may want to consider setting a higher value by default, but happy to consider that separately.

@niloc132
Copy link
Member Author

Do we know if there is a technical reason why jetty uses the "low" default of 128 for maxConcurrentStreams? We may want to consider setting a higher value by default, but happy to consider that separately.

jetty/jetty.project@5073ba4 is this commit where this was changed from -1 to 128, there isn't a lot of specific detail there.

The http2 spec itself says this should be not less than 100 - I suspect they just took a power of two higher than 100.

SETTINGS_MAX_CONCURRENT_STREAMS (0x3):

Indicates the maximum number of concurrent streams that the sender will allow. This limit is directional: it applies to the number of streams that the sender permits the receiver to create. Initially, there is no limit to this value. It is recommended that this value be no smaller than 100, so as to not unnecessarily limit parallelism.

@niloc132 niloc132 merged commit 6cb5d7d into deephaven:main Sep 10, 2024
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable maximum allowed size of http requests java-client seems to be limited to about 128 streams
2 participants