-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improvements to the S3 API #6028
Open
malhotrashivam
wants to merge
6
commits into
deephaven:main
Choose a base branch
from
malhotrashivam:sm-s3-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhotrashivam
added
parquet
Related to the Parquet integration
DocumentationNeeded
ReleaseNotesNeeded
Release notes are needed
s3
labels
Sep 6, 2024
malhotrashivam
requested review from
chipkent,
jmao-denver and
rcaudy
as code owners
September 6, 2024 18:22
malhotrashivam
commented
Sep 6, 2024
extensions/s3/src/main/java/io/deephaven/extensions/s3/S3AsyncClientFactory.java
Outdated
Show resolved
Hide resolved
malhotrashivam
changed the title
feat: [DO NOT MERGE] Improvements to the S3 API
feat: Improvements to the S3 API
Sep 6, 2024
devinrsmith
reviewed
Sep 6, 2024
extensions/s3/src/main/java/io/deephaven/extensions/s3/Credentials.java
Outdated
Show resolved
Hide resolved
extensions/s3/src/main/java/io/deephaven/extensions/s3/S3AsyncClientFactory.java
Outdated
Show resolved
Hide resolved
extensions/s3/src/main/java/io/deephaven/extensions/s3/S3AsyncClientFactory.java
Outdated
Show resolved
Hide resolved
devinrsmith
reviewed
Sep 6, 2024
malhotrashivam
commented
Sep 16, 2024
extensions/s3/src/main/java/io/deephaven/extensions/s3/S3AsyncClientFactory.java
Show resolved
Hide resolved
devinrsmith
reviewed
Sep 20, 2024
extensions/s3/src/main/java/io/deephaven/extensions/s3/S3AsyncClientFactory.java
Outdated
Show resolved
Hide resolved
devinrsmith
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DocumentationNeeded
parquet
Related to the Parquet integration
ReleaseNotesNeeded
Release notes are needed
s3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6016, #6017
TODO: Add documentation update