Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Make it easier to manually run GWT tests from the IDE #5725

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

niloc132
Copy link
Member

@niloc132 niloc132 commented Jul 5, 2024

Summary from the task description:

Test wiring to run either unit or integration tests with a manual browser and an already-running server. This makes it easier to run a tests repeatedly, either one at a time or as a class/suite, without paying to start/stop selenium and deephaven each time. The port will remain constant at 8888 each run to let breakpoints continue to work across repeated runs.

To use this, first start a server on port 10000 with anonymous access enabled. Then, either select a test in IntelliJ to run using the manualGwtTest task, or invoke from the command line with info logging enabled and a specific test selected, e.g.:

./gradlew :web-client-api:manualGwtTest --info --tests io.deephaven.web.client.api.NullValueTestGwt

Click the URL that is printed out to run the test in your browser, or refresh an existing browser window.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, this is great. Just a minor suggestion to clean up the wording a bit.

logging enabled and a specific test selected, e.g.:
./gradlew :web-client-api:manualGwtTest --info --tests io.deephaven.web.client.api.NullValueTestGwt

When the URL appears to run in your browser, click on it, or refresh an existing browser window.'''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of confused when I first read this, suggest modifying the wording a bit.

Suggested change
When the URL appears to run in your browser, click on it, or refresh an existing browser window.'''
Click the URL that is printed out to run the test in your browser, or refresh an existing browser window.'''

@niloc132 niloc132 requested a review from mofojed July 5, 2024 18:42
@niloc132 niloc132 merged commit d7afa8e into deephaven:main Jul 11, 2024
18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants