Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cppclient): Remove extension from dhclient and dhcore for cross-platform compatibility #5706

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

kosak
Copy link
Contributor

@kosak kosak commented Jul 2, 2024

Windows expects a ".dll" suffix, and Linux expects ".so", but the machinery behind LibraryImport seems to know to do the right thing.

@kosak kosak added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Jul 2, 2024
@kosak kosak requested a review from jcferretti July 2, 2024 03:34
@kosak kosak self-assigned this Jul 2, 2024
@kosak kosak enabled auto-merge (squash) July 2, 2024 03:35
@kosak kosak merged commit ff09e29 into deephaven:main Jul 2, 2024
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
@kosak kosak deleted the kosak_remove-extension branch July 2, 2024 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants