Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cppclient): Clarify a comment explaining why a test is disabled, … #5705

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix(cppclient): Clarify a comment explaining why a test is disabled, … #5705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cpp-client/deephaven/tests/src/ungroup_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,17 @@
#include "deephaven/tests/test_util.h"

namespace deephaven::client::tests {
// TODO(kosak): This test is currently disabled (by membership in the [.] test group, because we
// don't yet deserialize the grouped column correctly.
// TODO(kosak): This test is currently disabled (by membership in the [.] test group).
// The reason is because each cell in the grouped column comes back as the Arrow type list<double>,
// but the library does not currently know how to deserialize Arrow list types.
TEST_CASE("Ungroup columns", "[.]") {
auto tm = TableMakerForTests::Create();
auto table = tm.Table();

table = table.Where("ImportDate == `2017-11-01`");

auto by_table = table.Where("Ticker == `AAPL`").View("Ticker", "Close").View("Ticker");
auto by_table = table.Where("Ticker == `AAPL`").View("Ticker", "Close").By("Ticker");
std::cout << by_table.Stream(true) << '\n';
auto ungrouped = by_table.Ungroup("Close");

std::vector<std::string> ticker_data = {"AAPL"};
Expand Down
Loading