chore: Upgrade jedi to 0.19.1 #5693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrunyon
requested review from
chipkent,
jmao-denver,
rcaudy,
devinrsmith and
jcferretti
as code owners
jmao-denver
added
NoDocumentationNeeded
ReleaseNotesNeeded
|
Two questions:
|
devinrsmith
requested changes
Jun 28, 2024
| @@ -1,3 +1,3 @@ | |||
| io.deephaven.project.ProjectType=DOCKER_REGISTRY | |||
| deephaven.registry.imageName=ghcr.io/deephaven/server-slim-base:edge | |||
| deephaven.registry.imageId=ghcr.io/deephaven/server-slim-base@sha256:ca9b55d2e075dc12e220b8cb13fdd9cd4cb7fc8f68dfdaba99fc240f5a916266 | |||
| deephaven.registry.imageId=ghcr.io/deephaven/server-slim-base@sha256:8011b73d42aebf3d240c25e2b0a12c21dbc0049fa8444924fe9f9dbeb1ca9ddfs | |||
There was a problem hiding this comment.
This is not a valid digest. I think you added an extra "s" onto the end. Clearly, our CI build doesn't even use this image, otherwise it would have failed... :/
devinrsmith
approved these changes
Jun 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Python 3.11 and 3.12.
Also, the 0.19.0 changelog notes a massive performance improvement for
Interpretermode which we use by default. It felt a bit snappier to me while using it locally.Also adds a new flag to avoid unsafe execution if we want to enable that. Not sure what the default is based on the changelog.
https://jedi.readthedocs.io/en/latest/docs/changelog.html