Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ Client: End of Barrage stream should throw; reformat exception messages #5682

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

kosak
Copy link
Contributor

@kosak kosak commented Jun 26, 2024

There are two changes in this PR.

  1. At the end of a Barrage stream, throw exception rather than segfault.
  2. Reformat exception messages to put the message first (before pathname and line number) rather than after.

Rationale:

  1. Under normal Deephaven operation, Barrage streams don't really end (unless cancelled by the user). But I noticed that sometimes if you kill the server, the client will receive an "end of stream" indication that it is not expecting. This situation is indicated by a null in the data field. When we get this null, throw an exception.
  2. Putting the exception message first rather than last makes it more readable to the user (especially my Excel users who would like to see the cause at the beginning of their cell rather than a long pathname).

@kosak kosak added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Jun 26, 2024
@kosak kosak self-assigned this Jun 26, 2024
@kosak kosak enabled auto-merge (squash) June 26, 2024 22:34
@kosak kosak merged commit 093609f into deephaven:main Jun 26, 2024
18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2024
@kosak kosak deleted the kosak_barrage-eos-throws branch June 27, 2024 02:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants