-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add concrete JsPlugin #4925
Merged
Merged
Add concrete JsPlugin #4925
Commits on Dec 7, 2023
-
This PR gives a concrete structure to JsPlugin; name, version, main, root, and paths. All existing means of configuration for JS plugins delegates to JsPlugin. Java jars can now provide JS plugins with this change as well. This is also a _partial_ improvement for deephaven#4817 (JS Plugins development is slow), in that JsPlugin paths is a mean to reduce the scope of files that needs to be copied. This is _not_ a full solution (which may involve routing paths in Jetty that lead directly to the resources as configured via the JS plugins). For NPM packages, this PR takes a practical approach as opposed to a "perfect" approach; we are requiring that all "real" files be included under the top-level directory as specified by package.json/main. For example, if main is "build/index.js", we'll include everything under "build/". If main is "dist/bundle/index.js", we'll include everything under "dist/". The inclusion of the matching python structures will follow shortly, either as additional commits to this PR, or as follow-up PR. Adds testing, fixes deephaven#4893
Configuration menu - View commit details
-
Copy full SHA for 7808908 - Browse repository at this point
Copy the full SHA 7808908View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3ccbc1 - Browse repository at this point
Copy the full SHA e3ccbc1View commit details
Commits on Dec 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2fed742 - Browse repository at this point
Copy the full SHA 2fed742View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd6f098 - Browse repository at this point
Copy the full SHA bd6f098View commit details
Commits on Dec 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 947a5ec - Browse repository at this point
Copy the full SHA 947a5ecView commit details
Commits on Dec 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 24c6063 - Browse repository at this point
Copy the full SHA 24c6063View commit details
Commits on Dec 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bcde5ff - Browse repository at this point
Copy the full SHA bcde5ffView commit details
Commits on Dec 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3eb9c3d - Browse repository at this point
Copy the full SHA 3eb9c3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5132e10 - Browse repository at this point
Copy the full SHA 5132e10View commit details -
Configuration menu - View commit details
-
Copy full SHA for c23950f - Browse repository at this point
Copy the full SHA c23950fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0522799 - Browse repository at this point
Copy the full SHA 0522799View commit details
Commits on Dec 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 60731f1 - Browse repository at this point
Copy the full SHA 60731f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for eece802 - Browse repository at this point
Copy the full SHA eece802View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8fe591 - Browse repository at this point
Copy the full SHA d8fe591View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.