Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concrete JsPlugin #4925

Merged
merged 14 commits into from
Dec 14, 2023
Merged

Add concrete JsPlugin #4925

merged 14 commits into from
Dec 14, 2023

Commits on Dec 7, 2023

  1. Add concrete JsPlugin

    This PR gives a concrete structure to JsPlugin; name, version, main, root, and paths. All existing means of configuration for JS plugins delegates to JsPlugin. Java jars can now provide JS plugins with this change as well.
    
    This is also a _partial_ improvement for deephaven#4817 (JS Plugins development is slow), in that JsPlugin paths is a mean to reduce the scope of files that needs to be copied. This is _not_ a full solution (which may involve routing paths in Jetty that lead directly to the resources as configured via the JS plugins).
    
    For NPM packages, this PR takes a practical approach as opposed to a "perfect" approach; we are requiring that all "real" files be included under the top-level directory as specified by package.json/main. For example, if main is "build/index.js", we'll include everything under "build/". If main is "dist/bundle/index.js", we'll include everything under "dist/".
    
    The inclusion of the matching python structures will follow shortly, either as additional commits to this PR, or as follow-up PR.
    
    Adds testing, fixes deephaven#4893
    devinrsmith committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    7808908 View commit details
    Browse the repository at this point in the history
  2. cleanup

    devinrsmith committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    e3ccbc1 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Configuration menu
    Copy the full SHA
    2fed742 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bd6f098 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. Review responses

    devinrsmith committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    947a5ec View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Make work w/ zip FS

    devinrsmith committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    24c6063 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. f

    devinrsmith committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    bcde5ff View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Renames

    devinrsmith committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    3eb9c3d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5132e10 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c23950f View commit details
    Browse the repository at this point in the history
  4. Update to_j_js_plugin

    devinrsmith committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    0522799 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Review response

    devinrsmith committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    60731f1 View commit details
    Browse the repository at this point in the history
  2. remove part

    devinrsmith committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    eece802 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d8fe591 View commit details
    Browse the repository at this point in the history