Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add BigInteger and BigDecimal types to MatchFilter.java #4912

Merged
merged 4 commits into from
Dec 25, 2023
Merged

fix: Add BigInteger and BigDecimal types to MatchFilter.java #4912

merged 4 commits into from
Dec 25, 2023

Conversation

georgecwan
Copy link
Contributor

Added cases for java.math.BigDecimal and java.math.BigInteger to MatchFilter.java.

Fixes #4911.

@georgecwan georgecwan self-assigned this Dec 4, 2023
@georgecwan georgecwan requested review from niloc132 and removed request for mofojed December 4, 2023 20:47
niloc132
niloc132 reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for these column types in WhereFilterFactoryTest (and anywhere else appropriate you see)

@niloc132
Copy link
Member

Two small nits, looks good otherwise

georgecwan and others added 2 commits December 22, 2023 08:53
@georgecwan @niloc132
Update engine/table/src/test/java/io/deephaven/engine/table/impl/sele…
8eda1b9 
…ct/WhereFilterFactoryTest.java

Co-authored-by: Colin Alworth <[email protected]>
@georgecwan @niloc132
Update engine/table/src/test/java/io/deephaven/engine/table/impl/sele…
f811e63 
…ct/WhereFilterFactoryTest.java

Co-authored-by: Colin Alworth <[email protected]>
@georgecwan georgecwan merged commit ecebae9 into deephaven:main Dec 25, 2023
19 checks passed
@georgecwan georgecwan deleted the 4911-biginteger-bigdecimal-filter branch December 25, 2023 21:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niloc132 niloc132 niloc132 approved these changes

Assignees

@georgecwan georgecwan

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to filter on BigDecimal and BigInteger columns
2 participants
@georgecwan @niloc132