Add the optional dependencies parameters in the transform/partitioned_transform methods #4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmao-denver
added
DocumentationNeeded
python-server-side
ReleaseNotesNeeded
jmao-denver
force-pushed
the
4890-add-dependencies-transform
branch
from
035d92d
to
f4ad2b7
Compare
rcaudy
reviewed
Nov 29, 2023
Co-authored-by: Ryan Caudy <[email protected]>
rcaudy
previously approved these changes
Nov 29, 2023
chipkent
reviewed
Nov 29, 2023
py/server/deephaven/table.py
Outdated
Comment on lines
2688
to
2689
| j_dependencies = [d.j_table for d in dependencies if isinstance(d, Table)] | ||
| j_dependencies.extend([d.table.j_table for d in dependencies if isinstance(d, PartitionedTable)]) |
There was a problem hiding this comment.
There should be a size assert because this will happily run if non Table / PartitionedTable garbage is included.
There was a problem hiding this comment.
It might be an overkill, I think it is safe to assume that users who need to use this parameter knows what they are doing.
There was a problem hiding this comment.
Will Python's type system (hah) allow that?
rcaudy
approved these changes
Nov 29, 2023
chipkent
approved these changes
Nov 29, 2023
|
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/3496 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4890