ExportObject PUBLISHING State Change Bug #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
bug
nbauernfeind
changed the title
rcaudy
approved these changes
Nov 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my query performance recorder change branch -- I've discovered failures around
DoPutandSessionService#publishTicketFromExport. When adding theExportObject#onSuccesscallback, I also added some enforcement that exports move through a specific ordering. Published items "walk backward" one step to PENDING before going into QUEUED. This is unnecessary (they should never have intermediary dependencies, too -- you can always add a non-export before (it performs the publish) or after the publish (dependent on the publish)).I have this fix in that branch, but the issue was introduced in v0.30.0.
Note that it would be inappropriate to change the enum ordering as this lives in the proto file and known by client code.